Skip to content

Commit 9ef84a6

Browse files
committed
Dialog: Style updates
Ref #14246 Ref gh-1588
1 parent f75c876 commit 9ef84a6

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

tests/unit/dialog/common-deprecated.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ common.testWidget( "dialog", {
3636
title: null,
3737
width: 300,
3838

39-
// callbacks
39+
// Callbacks
4040
beforeClose: null,
4141
close: null,
4242
create: null,

tests/unit/dialog/common.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ common.testWidget( "dialog", {
3535
title: null,
3636
width: 300,
3737

38-
// callbacks
38+
// Callbacks
3939
beforeClose: null,
4040
close: null,
4141
create: null,

tests/unit/dialog/core.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ asyncTest( "Prevent tabbing out of dialogs", function() {
224224
function checkTab() {
225225
equal( document.activeElement, inputs[ 0 ], "Tab key event moved focus within the modal" );
226226

227-
// check shift tab
227+
// Check shift tab
228228
$( document.activeElement ).simulate( "keydown", { keyCode: $.ui.keyCode.TAB, shiftKey: true });
229229
setTimeout( checkShiftTab );
230230
}

tests/unit/dialog/events.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ test( "focus", function() {
7676
other.dialog( "moveToTop" );
7777
element.trigger( "mousedown" );
7878

79-
// triggers just once when already on top
79+
// Triggers just once when already on top
8080
element.dialog( "open" );
8181
element.dialog( "moveToTop" );
8282
element.trigger( "mousedown" );

tests/unit/dialog/options.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ test("minWidth", function( assert ) {
344344
test( "position, default center on window", function( assert ) {
345345
expect( 2 );
346346

347-
// dialogs alter the window width and height in Firefox
347+
// Dialogs alter the window width and height in Firefox
348348
// so we collect that information before creating the dialog
349349
// Support: Firefox
350350
var winWidth = $( window ).width(),
@@ -360,7 +360,7 @@ test( "position, default center on window", function( assert ) {
360360
test( "position, right bottom at right bottom via ui.position args", function( assert ) {
361361
expect( 2 );
362362

363-
// dialogs alter the window width and height in Firefox
363+
// Dialogs alter the window width and height in Firefox
364364
// so we collect that information before creating the dialog
365365
// Support: Firefox
366366
var winWidth = $( window ).width(),
@@ -469,7 +469,7 @@ test( "title", function() {
469469
equal( titleText(), "foo", "title after init" );
470470
element.remove();
471471

472-
// make sure attroperties are properly ignored - #5742 - .attr() might return a DOMElement
472+
// Make sure attroperties are properly ignored - #5742 - .attr() might return a DOMElement
473473
element = $( "<form><input name='title'></form>" ).dialog();
474474
// some browsers return a non-breaking space and some return "&nbsp;"
475475
// so we get the text to normalize to the actual non-breaking space

ui/widgets/dialog.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ $.widget( "ui.dialog", {
8181
title: null,
8282
width: 300,
8383

84-
// callbacks
84+
// Callbacks
8585
beforeClose: null,
8686
close: null,
8787
drag: null,
@@ -353,7 +353,7 @@ $.widget( "ui.dialog", {
353353
return;
354354
}
355355

356-
// prevent tabbing out of dialogs
356+
// Prevent tabbing out of dialogs
357357
if ( event.keyCode !== $.ui.keyCode.TAB || event.isDefaultPrevented() ) {
358358
return;
359359
}
@@ -408,7 +408,7 @@ $.widget( "ui.dialog", {
408408
}
409409
} );
410410

411-
// support: IE
411+
// Support: IE
412412
// Use type="button" to prevent enter keypresses in textboxes from closing the
413413
// dialog in IE (#9312)
414414
this.uiDialogTitlebarClose = $( "<button type='button'></button>" )
@@ -464,7 +464,7 @@ $.widget( "ui.dialog", {
464464
var that = this,
465465
buttons = this.options.buttons;
466466

467-
// if we already have a button pane, remove it
467+
// If we already have a button pane, remove it
468468
this.uiDialogButtonPane.remove();
469469
this.uiButtonSet.empty();
470470

@@ -722,12 +722,12 @@ $.widget( "ui.dialog", {
722722
uiDialog.resizable( "destroy" );
723723
}
724724

725-
// currently resizable, changing handles
725+
// Currently resizable, changing handles
726726
if ( isResizable && typeof value === "string" ) {
727727
uiDialog.resizable( "option", "handles", value );
728728
}
729729

730-
// currently non-resizable, becoming resizable
730+
// Currently non-resizable, becoming resizable
731731
if ( !isResizable && value !== false ) {
732732
this._makeResizable();
733733
}
@@ -756,7 +756,7 @@ $.widget( "ui.dialog", {
756756
options.width = options.minWidth;
757757
}
758758

759-
// reset wrapper sizing
759+
// Reset wrapper sizing
760760
// determine the height of all the non-content elements
761761
nonContentHeight = this.uiDialog.css( {
762762
height: "auto",

0 commit comments

Comments
 (0)