Skip to content

Commit a129a93

Browse files
committed
Slider: Add disabled tests and remove disabled prop from handles
1 parent a61af0b commit a129a93

File tree

2 files changed

+31
-3
lines changed

2 files changed

+31
-3
lines changed

tests/unit/slider/slider_options.js

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,37 @@ function handle() {
1111

1212
module("slider: options");
1313

14+
test( "disabled", function(){
15+
expect( 8 );
16+
var count = 0;
17+
18+
el = $( "#slider1" ).slider();
19+
el.on( "slidestart", function() {
20+
count++;
21+
});
22+
23+
// enabled
24+
ok( !el.hasClass( "ui-slider-disabled" ), "no disabled class" );
25+
equal( el.slider( "option", "disabled" ), false , "is not disabled" );
26+
27+
handle().simulate( "drag", { dx: 10 } );
28+
equal( count, 1, "slider moved");
29+
30+
handle().simulate("keydown", { keyCode: $.ui.keyCode.RIGHT });
31+
equal( count, 2, "slider moved");
32+
33+
// disabled
34+
el.slider( "option", "disabled", true );
35+
ok( el.hasClass( "ui-slider-disabled" ), "has disabled class" );
36+
equal( el.slider( "option", "disabled" ), true, "is disabled" );
37+
38+
handle().simulate( "drag", { dx: 10 } );
39+
equal( count, 2, "slider did not move");
40+
41+
handle().simulate("keydown", { keyCode: $.ui.keyCode.RIGHT });
42+
equal( count, 2, "slider did not move");
43+
});
44+
1445
test("max", function() {
1546
expect( 2 );
1647
el = $("<div></div>");

ui/jquery.ui.slider.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -412,9 +412,6 @@ $.widget( "ui.slider", $.ui.mouse, {
412412
if ( value ) {
413413
this.handles.filter( ".ui-state-focus" ).blur();
414414
this.handles.removeClass( "ui-state-hover" );
415-
this.handles.prop( "disabled", true );
416-
} else {
417-
this.handles.prop( "disabled", false );
418415
}
419416
break;
420417
case "orientation":

0 commit comments

Comments
 (0)