Skip to content

Commit c2a9aa6

Browse files
committed
Spinner: Remove redundant handling of disabled option on create
Ref #9151
1 parent cab1363 commit c2a9aa6

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

ui/widgets/spinner.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -268,11 +268,6 @@ $.widget( "ui.spinner", {
268268
this.uiSpinner.height() > 0 ) {
269269
this.uiSpinner.height( this.uiSpinner.height() );
270270
}
271-
272-
// Disable spinner if element was already disabled
273-
if ( this.options.disabled ) {
274-
this.disable();
275-
}
276271
},
277272

278273
_keydown: function( event ) {
@@ -429,12 +424,18 @@ $.widget( "ui.spinner", {
429424
this._super( key, value );
430425

431426
if ( key === "disabled" ) {
432-
this._toggleClass( this.uiSpinner, null, "ui-state-disabled", !!value );
433-
this.element.prop( "disabled", !!value );
434-
this.buttons.button( value ? "disable" : "enable" );
427+
this._setOptionDisabled( value );
435428
}
436429
},
437430

431+
_setOptionDisabled: function( value ) {
432+
this._super( value );
433+
434+
this._toggleClass( this.uiSpinner, null, "ui-state-disabled", !!value );
435+
this.element.prop( "disabled", !!value );
436+
this.buttons.button( value ? "disable" : "enable" );
437+
},
438+
438439
_setOptions: spinnerModifer( function( options ) {
439440
this._super( options );
440441
} ),

0 commit comments

Comments
 (0)