Skip to content

Commit e4273ff

Browse files
committed
Autocomplet: refactored handling of menu's selected event.
1 parent 2ed96cb commit e4273ff

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

ui/jquery.ui.autocomplete.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,23 +123,20 @@ $.widget( "ui.autocomplete", {
123123
},
124124
selected: function( event, ui ) {
125125
var item = ui.item.data( "item.autocomplete" ),
126-
setValue = false;
127-
if ( false !== self._trigger( "select", event, { item: item } ) ) {
128-
// #5639 - if we set the value before setting focus
129-
// the cursor will move to the beginning of the field in IE
130-
setValue = true;
131-
}
132-
self.close( event );
126+
previous = self.previous;
127+
133128
// only trigger when focus was lost (click on menu)
134-
var previous = self.previous;
135129
if ( self.element[0] !== doc.activeElement ) {
136130
self.element.focus();
137131
self.previous = previous;
138132
}
139-
self.selectedItem = item;
140-
if ( setValue ) {
133+
134+
if ( false !== self._trigger( "select", event, { item: item } ) ) {
141135
self.element.val( item.value );
142136
}
137+
138+
self.close( event );
139+
self.selectedItem = item;
143140
},
144141
blur: function( event, ui ) {
145142
if ( self.menu.element.is(":visible") ) {

0 commit comments

Comments
 (0)