Skip to content

Commit edfc863

Browse files
scottgonzalezscottgonzalez
committed
Widget Tests: Coding standards.
1 parent 001b4b0 commit edfc863

File tree

1 file changed

+83
-79
lines changed

1 file changed

+83
-79
lines changed

‎tests/unit/widget/widget_core.js‎

Lines changed: 83 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -1,122 +1,126 @@
11
/*
22
* widget unit tests
33
*/
4-
(function($) {
4+
(function( $ ) {
55

6-
module('widget factory', {
6+
module( "widget factory", {
77
teardown: function() {
88
delete $.ui.testWidget;
99
}
1010
});
1111

12-
test('widget creation', function() {
12+
test( "widget creation", function() {
1313
var myPrototype = {
1414
_create: function() {},
1515
creationTest: function() {}
1616
};
17-
18-
$.widget('ui.testWidget', myPrototype);
19-
ok($.isFunction($.ui.testWidget), 'constructor was created');
20-
equals('object', typeof $.ui.testWidget.prototype, 'prototype was created');
21-
equals($.ui.testWidget.prototype._create, myPrototype._create, 'create function is copied over');
22-
equals($.ui.testWidget.prototype.creationTest, myPrototype.creationTest, 'random function is copied over');
23-
equals($.ui.testWidget.prototype.option, $.Widget.prototype.option, 'option method copied over from base widget');
17+
18+
$.widget( "ui.testWidget", myPrototype );
19+
ok( $.isFunction( $.ui.testWidget ), "constructor was created" );
20+
equals( "object", typeof $.ui.testWidget.prototype, "prototype was created" );
21+
equals( $.ui.testWidget.prototype._create, myPrototype._create,
22+
"create function is copied over" );
23+
equals( $.ui.testWidget.prototype.creationTest, myPrototype.creationTest,
24+
"random function is copied over" );
25+
equals( $.ui.testWidget.prototype.option, $.Widget.prototype.option,
26+
"option method copied over from base widget" );
2427
});
2528

26-
test('jQuery usage', function() {
27-
expect(10);
28-
29+
test( "jQuery usage", function() {
30+
expect( 10 );
31+
2932
var shouldInit = false;
30-
31-
$.widget('ui.testWidget', {
33+
34+
$.widget( "ui.testWidget", {
3235
getterSetterVal: 5,
3336
_create: function() {
34-
ok(shouldInit, 'init called on instantiation');
37+
ok( shouldInit, "init called on instantiation" );
3538
},
36-
methodWithParams: function(param1, param2) {
37-
ok(true, 'method called via .pluginName(methodName)');
38-
equals(param1, 'value1',
39-
'parameter passed via .pluginName(methodName, param)');
40-
equals(param2, 'value2',
41-
'multiple parameters passed via .pluginName(methodName, param, param)');
39+
methodWithParams: function( param1, param2 ) {
40+
ok( true, "method called via .pluginName(methodName)" );
41+
equals( param1, "value1",
42+
"parameter passed via .pluginName(methodName, param)" );
43+
equals( param2, "value2",
44+
"multiple parameters passed via .pluginName(methodName, param, param)" );
4245

4346
return this;
4447
},
45-
getterSetterMethod: function(val) {
46-
if (val) {
48+
getterSetterMethod: function( val ) {
49+
if ( val ) {
4750
this.getterSetterVal = val;
4851
} else {
4952
return this.getterSetterVal;
5053
}
5154
}
5255
});
53-
56+
5457
shouldInit = true;
55-
var elem = $('<div></div>').testWidget();
58+
var elem = $( "<div></div>" ).testWidget();
5659
shouldInit = false;
57-
58-
var instance = elem.data('testWidget');
59-
equals(typeof instance, 'object', 'instance stored in .data(pluginName)');
60-
equals(instance.element[0], elem[0], 'element stored on widget');
61-
var ret = elem.testWidget('methodWithParams', 'value1', 'value2');
62-
equals(ret, elem, 'jQuery object returned from method call');
63-
64-
ret = elem.testWidget('getterSetterMethod');
65-
equals(ret, 5, 'getter/setter can act as getter');
66-
ret = elem.testWidget('getterSetterMethod', 30);
67-
equals(ret, elem, 'getter/setter method can be chainable');
68-
equals(instance.getterSetterVal, 30, 'getter/setter can act as setter');
60+
61+
var instance = elem.data( "testWidget" );
62+
equals( typeof instance, "object", "instance stored in .data(pluginName)" );
63+
equals( instance.element[0], elem[0], "element stored on widget" );
64+
var ret = elem.testWidget( "methodWithParams", "value1", "value2" );
65+
equals( ret, elem, "jQuery object returned from method call" );
66+
67+
ret = elem.testWidget( "getterSetterMethod" );
68+
equals( ret, 5, "getter/setter can act as getter" );
69+
ret = elem.testWidget( "getterSetterMethod", 30 );
70+
equals( ret, elem, "getter/setter method can be chainable" );
71+
equals( instance.getterSetterVal, 30, "getter/setter can act as setter" );
6972
});
7073

71-
test('direct usage', function() {
72-
expect(9);
73-
74+
test( "direct usage", function() {
75+
expect( 9 );
76+
7477
var shouldInit = false;
75-
76-
$.widget('ui.testWidget', {
78+
79+
$.widget( "ui.testWidget", {
7780
getterSetterVal: 5,
7881
_create: function() {
79-
ok(shouldInit, 'init called on instantiation');
82+
ok( shouldInit, "init called on instantiation" );
8083
},
81-
methodWithParams: function(param1, param2) {
82-
ok(true, 'method called dirctly');
83-
equals(param1, 'value1', 'parameter passed via direct call');
84-
equals(param2, 'value2', 'multiple parameters passed via direct call');
85-
84+
methodWithParams: function( param1, param2 ) {
85+
ok( true, "method called dirctly" );
86+
equals( param1, "value1", "parameter passed via direct call" );
87+
equals( param2, "value2", "multiple parameters passed via direct call" );
88+
8689
return this;
8790
},
88-
getterSetterMethod: function(val) {
89-
if (val) {
91+
getterSetterMethod: function( val ) {
92+
if ( val ) {
9093
this.getterSetterVal = val;
9194
} else {
9295
return this.getterSetterVal;
9396
}
9497
}
9598
});
9699

97-
var elem = $('<div></div>')[0];
100+
var elem = $( "<div></div>" )[ 0 ];
98101

99102
shouldInit = true;
100-
var instance = new $.ui.testWidget({}, elem);
103+
var instance = new $.ui.testWidget( {}, elem );
101104
shouldInit = false;
105+
106+
equals( $( elem ).data( "testWidget" ), instance,
107+
"instance stored in .data(pluginName)" );
108+
equals( instance.element[ 0 ], elem, "element stored on widget" );
102109

103-
equals($(elem).data('testWidget'), instance, 'instance stored in .data(pluginName)');
104-
equals(instance.element[0], elem, 'element stored on widget');
105-
106-
var ret = instance.methodWithParams('value1', 'value2');
107-
equals(ret, instance, 'plugin returned from method call');
108-
110+
var ret = instance.methodWithParams( "value1", "value2" );
111+
equals( ret, instance, "plugin returned from method call" );
112+
109113
ret = instance.getterSetterMethod();
110-
equals(ret, 5, 'getter/setter can act as getter');
111-
instance.getterSetterMethod(30);
112-
equals(instance.getterSetterVal, 30, 'getter/setter can act as setter');
114+
equals( ret, 5, "getter/setter can act as getter" );
115+
instance.getterSetterMethod( 30 );
116+
equals( instance.getterSetterVal, 30, "getter/setter can act as setter" );
113117
});
114118

115-
test('merge multiple option arguments', function() {
116-
expect(1);
117-
$.widget("ui.testWidget", {
119+
test("merge multiple option arguments", function() {
120+
expect( 1 );
121+
$.widget( "ui.testWidget", {
118122
_create: function() {
119-
same(this.options, {
123+
same( this.options, {
120124
disabled: false,
121125
option1: "value1",
122126
option2: "value2",
@@ -128,7 +132,7 @@ test('merge multiple option arguments', function() {
128132
});
129133
}
130134
});
131-
$("<div></div>").testWidget({
135+
$( "<div></div>" ).testWidget({
132136
option1: "valuex",
133137
option2: "valuex",
134138
option3: "value3",
@@ -148,7 +152,7 @@ test('merge multiple option arguments', function() {
148152
});
149153
});
150154

151-
test("re-init", function() {
155+
test( "re-init", function() {
152156
var div = $( "<div></div>" ),
153157
actions = [];
154158

@@ -236,7 +240,7 @@ test( ".option() - setter", function() {
236240

237241
test( ".enable()", function() {
238242
expect( 2 );
239-
$.widget("ui.testWidget", {
243+
$.widget( "ui.testWidget", {
240244
_create: function() {},
241245
_setOption: function( key, val ) {
242246
same( key, "disabled", "_setOption called with disabled option" );
@@ -248,7 +252,7 @@ test( ".enable()", function() {
248252

249253
test( ".disable()", function() {
250254
expect( 2 );
251-
$.widget("ui.testWidget", {
255+
$.widget( "ui.testWidget", {
252256
_create: function() {},
253257
_setOption: function( key, val ) {
254258
same( key, "disabled", "_setOption called with disabled option" );
@@ -258,23 +262,23 @@ test( ".disable()", function() {
258262
$( "<div></div>" ).testWidget().testWidget( "disable" );
259263
});
260264

261-
test(".widget() - base", function() {
262-
$.widget("ui.testWidget", {
265+
test( ".widget() - base", function() {
266+
$.widget( "ui.testWidget", {
263267
_create: function() {}
264268
});
265-
var div = $("<div></div>").testWidget();
266-
same(div[0], div.testWidget("widget")[0]);
269+
var div = $( "<div></div>" ).testWidget();
270+
same( div[0], div.testWidget( "widget" )[0]);
267271
});
268272

269-
test(".widget() - overriden", function() {
270-
var wrapper = $("<div></div>");
271-
$.widget("ui.testWidget", {
273+
test( ".widget() - overriden", function() {
274+
var wrapper = $( "<div></div>" );
275+
$.widget( "ui.testWidget", {
272276
_create: function() {},
273277
widget: function() {
274278
return wrapper;
275279
}
276280
});
277-
same(wrapper[0], $("<div></div>").testWidget().testWidget("widget")[0]);
281+
same( wrapper[0], $( "<div></div>" ).testWidget().testWidget( "widget" )[0] );
278282
});
279283

280-
})(jQuery);
284+
})( jQuery );

0 commit comments

Comments
 (0)