Skip to content

Commit f115b48

Browse files
committed
Autocomplete: Don't handle remote data if it's not the most recent request. Fixes #5982 - Autocomplete: Race condition causes incorrect suggestions.
1 parent 1cca969 commit f115b48

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

ui/jquery.ui.autocomplete.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@ $.widget( "ui.autocomplete", {
210210
},
211211

212212
_initSource: function() {
213-
var array,
213+
var self = this,
214+
array,
214215
url;
215216
if ( $.isArray(this.options.source) ) {
216217
array = this.options.source;
@@ -220,7 +221,11 @@ $.widget( "ui.autocomplete", {
220221
} else if ( typeof this.options.source === "string" ) {
221222
url = this.options.source;
222223
this.source = function( request, response ) {
223-
$.getJSON( url, request, response );
224+
self.xhr = $.getJSON( url, request, function( data, status, xhr ) {
225+
if ( xhr === self.xhr ) {
226+
response.apply( this, arguments );
227+
}
228+
});
224229
};
225230
} else {
226231
this.source = this.options.source;

0 commit comments

Comments
 (0)