Skip to content

Commit f47c7fe

Browse files
authored
Tests: remove code supporting jenkins and testswarm
Close gh-2251
1 parent ec3edb6 commit f47c7fe

File tree

4 files changed

+4
-16
lines changed

4 files changed

+4
-16
lines changed

Gruntfile.js

-1
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ grunt.registerTask( "lint", [
397397
] );
398398
grunt.registerTask( "build", [ "requirejs", "concat" ] );
399399
grunt.registerTask( "default", [ "lint", "build" ] );
400-
grunt.registerTask( "jenkins", [ "build" ] );
401400
grunt.registerTask( "sizer", [ "requirejs:js", "uglify:main", "compare_size:all" ] );
402401
grunt.registerTask( "sizer_all", [ "requirejs:js", "uglify", "compare_size" ] );
403402

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
"load-grunt-tasks": "5.1.0",
7878
"rimraf": "4.4.1",
7979
"selenium-webdriver": "4.18.1",
80-
"testswarm": "1.1.2",
8180
"yargs": "17.7.2"
8281
},
8382
"keywords": []

tests/lib/bootstrap.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@ requirejs.config( {
1414
"qunit-assert-classes": "../../lib/vendor/qunit-assert-classes/qunit-assert-classes",
1515
"qunit-assert-close": "../../lib/vendor/qunit-assert-close/qunit-assert-close",
1616
"qunit": "../../../external/qunit/qunit",
17-
"testswarm": "https://swarm.jquery.org/js/inject.js?" + ( new Date() ).getTime(),
1817
"ui": "../../../ui"
1918
},
2019
shim: {
2120
"globalize/ja-JP": [ "globalize" ],
2221
"jquery-simulate": [ "jquery" ],
23-
"qunit-assert-close": [ "qunit" ],
24-
"testswarm": [ "qunit" ]
22+
"qunit-assert-close": [ "qunit" ]
2523
}
2624
} );
2725

@@ -69,11 +67,6 @@ function requireTests( dependencies, options ) {
6967

7068
dependencies = preDependencies.concat( dependencies );
7169

72-
// Load the TestSwarm injector, if necessary
73-
if ( parseUrl().swarmURL ) {
74-
dependencies.push( "testswarm" );
75-
}
76-
7770
requireModules( dependencies, function( QUnit ) {
7871
QUnit.start();
7972
} );

tests/unit/draggable/options.js

+3-6
Original file line numberDiff line numberDiff line change
@@ -1159,9 +1159,7 @@ QUnit.test( "#6817: auto scroll goes double distance when dragging", function( a
11591159
scroll: true,
11601160
stop: function( e, ui ) {
11611161
assert.equal( ui.offset.top, newY, "offset of item matches pointer position after scroll" );
1162-
1163-
// TODO: fix IE8 testswarm IFRAME positioning bug so assert.close can be turned back to equal
1164-
assert.close( ui.offset.top - offsetBefore.top, distance, 1, "offset of item only moves expected distance after scroll" );
1162+
assert.equal( ui.offset.top - offsetBefore.top, distance, 1, "offset of item only moves expected distance after scroll" );
11651163
}
11661164
} ),
11671165
scrollSensitivity = element.draggable( "option", "scrollSensitivity" ),
@@ -1217,9 +1215,8 @@ QUnit.test( "snap, snapMode, and snapTolerance", function( assert ) {
12171215
moves: 1
12181216
} );
12191217

1220-
// TODO: fix IE8 testswarm IFRAME positioning bug so assert.close can be turned back to equal
1221-
assert.close( element.offset().left, newX, 1, "doesn't snap outside the snapTolerance" );
1222-
assert.close( element.offset().top, newY, 1, "doesn't snap outside the snapTolerance" );
1218+
assert.equal( element.offset().left, newX, 1, "doesn't snap outside the snapTolerance" );
1219+
assert.equal( element.offset().top, newY, 1, "doesn't snap outside the snapTolerance" );
12231220

12241221
newX += 3;
12251222

0 commit comments

Comments
 (0)