(fix) Tests: Replace resource loader with AMD

Cleanup be3b2b2

Author: rxaviers

tests/unit/helper/jquery.js

@@ -6,12 +6,10 @@ if( !window.helper ) {
 
 window.helper.jqueryUrl = function() {
 
-	var parts = document.location.search.slice( 1 ).split( "&" ),
-		length = parts.length,
+	var current, url, version,
 		i = 0,
-		current,
-		version,
-		url;
+		length = parts.length,
+		parts = document.location.search.slice( 1 ).split( "&" );
 
 	for ( ; i < length; i++ ) {
 		current = parts[ i ].split( "=" );

tests/unit/helper/testsuite.js

@@ -8,7 +8,7 @@ var exports = {};
 function testWidgetDefaults( widget, defaults ) {
 	var pluginDefaults = $.ui[ widget ].prototype.options;
 
-	// ensure that all defaults have the correct value
+	// Ensure that all defaults have the correct value
 	test( "defined defaults", function() {
 		var count = 0;
 		$.each( defaults, function( key, val ) {
@@ -21,7 +21,7 @@ function testWidgetDefaults( widget, defaults ) {
 		});
 	});
 
-	// ensure that all defaults were tested
+	// Ensure that all defaults were tested
 	test( "tested defaults", function() {
 		var count = 0;
 		$.each( pluginDefaults, function( key ) {
@@ -59,14 +59,16 @@ function testBasicUsage( widget ) {
 		$( defaultElement )[ widget ]().remove();
 		ok( true, "initialized on disconnected DOMElement - never connected" );
 
+		// Ensure manipulating removed elements works (#3664)
 		$( defaultElement ).appendTo( "body" ).remove()[ widget ]().remove();
 		ok( true, "initialized on disconnected DOMElement - removed" );
 	});
 }
 
 // Asset revisioning through time and random hashing
 function revStamp( value ) {
-	return value + (/\?/.test(value) ? "&" : "?") + new Date().getTime() + "" + parseInt(Math.random() * 100000, 10);
+	return value + (/\?/.test(value) ? "&" : "?") + new Date().getTime() + "" +
+		parseInt(Math.random() * 100000, 10);
 }
 
 /**
@@ -89,8 +91,8 @@ exports.commonWidgetTests = function( widget, settings ) {
 /**
  * Experimental assertion for comparing DOM objects.
  *
- * Serializes an element and some properties and attributes and it's children if any, otherwise the text.
- * Then compares the result using deepEqual.
+ * Serializes an element and some properties and attributes and its children if any,
+ * otherwise the text. Then compares the result using deepEqual().
  */
 exports.domEqual = function( selector, modifier, message ) {
 	var expected, actual,

tests/unit/testsuite.js

@@ -9,7 +9,7 @@ window.TestHelpers = {};
 reset = QUnit.reset;
 QUnit.reset = function() {
 	// Ensure jQuery events and data on the fixture are properly removed
-	jQuery("#qunit-fixture").empty();
+	jQuery( "#qunit-fixture" ).empty();
 	// Let QUnit reset the fixture
 	reset.apply( this, arguments );
 };
@@ -44,7 +44,7 @@ QUnit.config.urlConfig.push({
 	tooltip: "Which jQuery Core version to test against"
 });
 
-TestHelpers.onFocus= function( element, onFocus ) {
+TestHelpers.onFocus = function( element, onFocus ) {
 	var fn = function( event ){
 		if( !event.originalEvent ) {
 			return;
@@ -57,6 +57,7 @@ TestHelpers.onFocus= function( element, onFocus ) {
 };
 
 TestHelpers.forceScrollableWindow = function( appendTo ) {
+
 	// The main testable area is 10000x10000 so to enforce scrolling,
 	// this DIV must be greater than 10000 to work
 	return $( "<div>" ).css({
@@ -65,12 +66,10 @@ TestHelpers.forceScrollableWindow = function( appendTo ) {
 	}).appendTo( appendTo || "#qunit-fixture" );
 };
 
-/*
- * Taken from https://github.com/jquery/qunit/tree/master/addons/close-enough
- */
+// Taken from https://github.com/jquery/qunit/tree/master/addons/close-enough
 window.closeEnough = function( actual, expected, maxDifference, message ) {
-	var passes = (actual === expected) || Math.abs(actual - expected) <= maxDifference;
-	QUnit.push(passes, actual, expected, message);
+	var passes = ( actual === expected ) || Math.abs( actual - expected ) <= maxDifference;
+	QUnit.push( passes, actual, expected, message );
 };
 
 });