Jerky corned beef short loin fatback jowl tail. Rump spare ribs shoulder pork belly. Sausage cow ground round bacon. Bresaola kielbasa pastrami brisket ham hock. Andouille kielbasa ham, pork beef tenderloin ground round beef ribs flank turkey pancetta tri-tip.
Shankle filet mignon ribeye chicken, bacon jowl drumstick frankfurter swine short loin capicola leberkas tenderloin pig. Shankle bacon shank pork loin, shoulder ham drumstick biltong. Shankle ham pastrami ball tip turkey leberkas pork loin ground round. Chicken strip steak venison shoulder biltong ham. Bacon pork loin tenderloin kielbasa, prosciutto sausage leberkas jowl ribeye turducken. Flank short loin venison tenderloin spare ribs boudin, tongue pork chop shank sirloin. Ground round ham pork belly, corned beef jowl strip steak short ribs prosciutto pig bresaola spare ribs.
-
+
Pork loin biltong ball tip tail jerky beef ribs prosciutto short loin turducken. Turkey chicken jowl pork loin shank tri-tip swine brisket. Doner prosciutto leberkas venison ground round, short loin capicola hamburger pork bacon. Spare ribs beef pork tenderloin rump shoulder pork belly turducken cow beef ribs pastrami tail flank. Spare ribs tri-tip shank, pork beef ribs ribeye chicken bacon boudin shoulder venison. Sirloin beef ribs boudin, andouille doner tail ball tip biltong prosciutto chicken beef turkey tongue hamburger tri-tip.
Doner salami jowl beef ribs. Pork chop beef short loin pork, kielbasa tail andouille salami sausage meatball short ribs t-bone tri-tip ham. Meatball short ribs prosciutto flank chicken fatback frankfurter brisket turducken. Corned beef hamburger swine short ribs pancetta. Jerky bresaola pork chuck spare ribs pastrami shoulder flank chicken leberkas beef.
diff --git a/tests/visual/index.html b/tests/visual/index.html index f7d516f2072..0c9b14da8d2 100644 --- a/tests/visual/index.html +++ b/tests/visual/index.html @@ -48,6 +48,7 @@Draggable
Effects
From 01f7f3c5fd45cc8fc4fd2ec28b668080c8cc8aa7 Mon Sep 17 00:00:00 2001 From: Mike SherovEXPECTED: Clicking "Toggle" or "Effect Toggle" a second time reverses the animation, first showing all elements at their original dimensions, and restoring them to their original state.
EXPECTED: Clicking "Effect Default" should always perform a "hide" animation.
EXPECTED: Clicking any of the buttons in quick succession should queue the relevant animations.
+EXPECTED CANTFIX: In IE8, the clip animation jumps due to a bug that causes .css('clip') to return undefined unless the clip property is an inline style.
From 8017d84a3c88eb6340068e1ace81b00870dcac00 Mon Sep 17 00:00:00 2001
From: Mike Sherov
Date: Sat, 15 Nov 2014 15:00:16 -0500
Subject: [PATCH 26/40] Effects Rewrite: Fix "unshift" method
---
ui/effect-bounce.js | 4 +++-
ui/effect-fold.js | 6 ++++--
ui/effect-pulsate.js | 5 +++--
ui/effect-shake.js | 5 ++++-
ui/effect.js | 9 ++++-----
5 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/ui/effect-bounce.js b/ui/effect-bounce.js
index 65ec684a018..224b0650a68 100644
--- a/ui/effect-bounce.js
+++ b/ui/effect-bounce.js
@@ -50,6 +50,8 @@ return $.effects.define( "bounce", function( o, done ) {
motion = ( direction === "up" || direction === "left" ),
i = 0,
+ queuelen = el.queue().length,
+
placeholder = $.effects.createPlaceholder( el ),
refValue = el.css( ref );
@@ -105,7 +107,7 @@ return $.effects.define( "bounce", function( o, done ) {
done();
});
- $.effects.unshift( el, anims + 1 );
+ $.effects.unshift( el, queuelen, anims + 1 );
});
}));
diff --git a/ui/effect-fold.js b/ui/effect-fold.js
index 8d26cff1aca..1d5996d6e49 100644
--- a/ui/effect-fold.js
+++ b/ui/effect-fold.js
@@ -51,7 +51,9 @@ return $.effects.define( "fold", "hide", function( o, done ) {
clip: el.cssClip()
},
- distance = [ start[ref[0]], start[ref[1]] ];
+ distance = [ start[ref[0]], start[ref[1]] ],
+
+ queuelen = el.queue().length;
// define animations
if ( percent ) {
@@ -93,7 +95,7 @@ return $.effects.define( "fold", "hide", function( o, done ) {
done();
});
- $.effects.unshift( el, 4 );
+ $.effects.unshift( el, queuelen, 4 );
});
}));
diff --git a/ui/effect-pulsate.js b/ui/effect-pulsate.js
index 032aa9fbca5..304848c8837 100644
--- a/ui/effect-pulsate.js
+++ b/ui/effect-pulsate.js
@@ -39,7 +39,8 @@ return $.effects.define( "pulsate", "show", function( o, done ) {
anims = ( ( o.times || 5 ) * 2 ) + ( showhide ? 1 : 0 ),
duration = o.duration / anims,
animateTo = 0,
- i = 1;
+ i = 1,
+ queuelen = elem.queue().length;
if ( show || !elem.is( ":visible" ) ) {
elem.css( "opacity", 0 ).show();
@@ -62,7 +63,7 @@ return $.effects.define( "pulsate", "show", function( o, done ) {
done();
});
- $.effects.unshift( elem, anims + 1 );
+ $.effects.unshift( elem, queuelen, anims + 1 );
});
}));
diff --git a/ui/effect-shake.js b/ui/effect-shake.js
index dd8cf334857..5857305a641 100644
--- a/ui/effect-shake.js
+++ b/ui/effect-shake.js
@@ -42,6 +42,9 @@ return $.effects.define( "shake", function( o, done ) {
animation = {},
animation1 = {},
animation2 = {},
+
+ queuelen = el.queue().length,
+
placeholder = $.effects.createPlaceholder( el );
// Animation
@@ -71,7 +74,7 @@ return $.effects.define( "shake", function( o, done ) {
done();
});
- $.effects.unshift( el, anims + 1 );
+ $.effects.unshift( el, queuelen, anims + 1 );
});
}));
diff --git a/ui/effect.js b/ui/effect.js
index ef6bd0cb419..6b61d0fc337 100644
--- a/ui/effect.js
+++ b/ui/effect.js
@@ -1065,13 +1065,12 @@ $.extend( $.effects, {
},
// Injects recently queued functions to be first in line (after "inprogress")
- unshift: function( el, count ) {
- var queue = el.queue(),
- queuelen = queue.length;
+ unshift: function( el, queueLength, count ) {
+ var queue = el.queue();
- if ( queuelen > count + 1 ) {
+ if ( queueLength > 1 ) {
queue.splice.apply( queue,
- [ 1, 0 ].concat( queue.splice( queuelen, count ) ) );
+ [ 1, 0 ].concat( queue.splice( queueLength, count ) ) );
}
el.dequeue();
},
From 77783f0bb3169a106de4e6719e977ff693cdbd86 Mon Sep 17 00:00:00 2001
From: Mike Sherov
Date: Mon, 17 Nov 2014 09:41:30 -0500
Subject: [PATCH 27/40] Effects Rewrite: Inline prefilter method
---
ui/effect.js | 37 +++++++++++++++----------------------
1 file changed, 15 insertions(+), 22 deletions(-)
diff --git a/ui/effect.js b/ui/effect.js
index 6b61d0fc337..e0180fb95ad 100644
--- a/ui/effect.js
+++ b/ui/effect.js
@@ -1290,8 +1290,7 @@ $.fn.extend({
effectMethod = $.effects.effect[ args.effect ],
defaultMode = effectMethod.mode,
modes = [],
- effectPrefilter = function() {
-
+ prefilter = function( next ) {
var el = $( this ),
normalizedMode = $.effects.mode( el, mode ) || defaultMode;
@@ -1300,21 +1299,22 @@ $.fn.extend({
// as the .show() below destroys the initial state
modes.push( normalizedMode );
- // see $.uiBackCompat inside of run() for removal in 1.13
- if ( defaultMode ) {
- if ( normalizedMode === "none" ) {
- return;
- }
+ // see $.uiBackCompat inside of run() for removal of defaultMode in 1.13
+ if ( defaultMode && ( normalizedMode === "show" ||
+ ( normalizedMode === defaultMode && normalizedMode === "hide" ) ) ) {
+ el.show();
+ }
- if ( normalizedMode === "show" ||
- ( normalizedMode === defaultMode && normalizedMode === "hide" ) ) {
- el.show();
- }
+ if ( !defaultMode || normalizedMode !== "none" ) {
+ $.effects.saveStyle( el );
}
- $.effects.saveStyle( el );
+ if ( $.isFunction( next ) ) {
+ next();
+ }
},
queue = args.queue,
+ queueName = queue || "fx",
complete = args.complete,
mode = args.mode;
@@ -1366,19 +1366,12 @@ $.fn.extend({
}
}
- function prefilter( next ) {
- effectPrefilter.call( this );
- if ( $.isFunction( next ) ) {
- next();
- }
- }
-
- // run prefilter on all elements first to ensure that
+ // Run prefilter on all elements first to ensure that
// any showing or hiding happens before placeholder creation,
- // which ensures that any layout changes are correctly captured
+ // which ensures that any layout changes are correctly captured.
return queue === false ?
this.each( prefilter ).each( run ) :
- this.queue( queue || "fx", prefilter ).queue( queue || "fx", run );
+ this.queue( queueName, prefilter ).queue( queueName, run );
},
show: (function( orig ) {
From 86c375fa4343f83db787685794fb8aa57c7a2b2a Mon Sep 17 00:00:00 2001
From: Mike Sherov
Date: Mon, 17 Nov 2014 10:05:06 -0500
Subject: [PATCH 28/40] Effects Rewrite: Fix style violations in
effects_core.js
---
tests/unit/effects/effects_core.js | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/unit/effects/effects_core.js b/tests/unit/effects/effects_core.js
index 7753f42c578..417dee074af 100644
--- a/tests/unit/effects/effects_core.js
+++ b/tests/unit/effects/effects_core.js
@@ -1,11 +1,11 @@
(function($) {
function present( value, array, message ) {
- QUnit.push( jQuery.inArray( value, array ) !== -1 , value, array, message );
+ QUnit.push( jQuery.inArray( value, array ) !== -1, value, array, message );
}
function notPresent( value, array, message ) {
- QUnit.push( jQuery.inArray( value, array ) === -1 , value, array, message );
+ QUnit.push( jQuery.inArray( value, array ) === -1, value, array, message );
}
// minDuration is used for "short" animate tests where we are only concerned about the final
@@ -229,11 +229,11 @@ $.each( $.effects.effect, function( effect ) {
}
hidden.queue( queueTest() ).show( effect, minDuration, queueTest(function() {
- equal( hidden.css("display"), "block", "Hidden is shown after .show(\"" +effect+ "\", time)" );
+ equal( hidden.css("display"), "block", "Hidden is shown after .show(\"" + effect + "\", time)" );
})).queue( queueTest() ).hide( effect, minDuration, queueTest(function() {
- equal( hidden.css("display"), "none", "Back to hidden after .hide(\"" +effect+ "\", time)" );
+ equal( hidden.css("display"), "none", "Back to hidden after .hide(\"" + effect + "\", time)" );
})).queue( queueTest(function() {
- deepEqual( hidden.queue(), ["inprogress"], "Only the inprogress sentinel remains");
+ deepEqual( hidden.queue(), [ "inprogress" ], "Only the inprogress sentinel remains");
start();
}));
});
From 4c2ffd9f61c903c77b035a3eba363b1eac772c89 Mon Sep 17 00:00:00 2001
From: Mike Sherov
Date: Mon, 17 Nov 2014 10:29:25 -0500
Subject: [PATCH 29/40] Effects Rewrite: Tests for createPlaceholder
---
tests/unit/effects/effects.html | 51 ++++++++++++++++++++----------
tests/unit/effects/effects_core.js | 38 ++++++++++++++++++++++
ui/effect.js | 16 +++++-----
3 files changed, 81 insertions(+), 24 deletions(-)
diff --git a/tests/unit/effects/effects.html b/tests/unit/effects/effects.html
index d6cfdb7973b..a092ce04bcf 100644
--- a/tests/unit/effects/effects.html
+++ b/tests/unit/effects/effects.html
@@ -88,28 +88,47 @@
width: 100px;
}
+ .relative {
+ position: relative;
+ top: 0px;
+ left: 0px;
+ }
+ .absolute {
+ position: absolute;
+ top: 0px;
+ left: 0px;
+ }
+ .fixed {
+ position: fixed;
+ top: 0px;
+ left: 0px;
+ }
+ .static {
+ position: static;
+ }
+
-
-
-
-
-.
-
-
-Child Element Test
-
-
-Slide with relative width
-
-
-
-
-
+
+
+
+ .
+
+
+ Child Element Test
+
+
+
+
+
+
+
+