Tabs: Rename ui-tab class to ui-tabs-tab for consistent prefixes #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't documented, but if we're going to deprecate, we should create a ticket for the deprecation and and a ticket for the removal. |
|
Created http://bugs.jqueryui.com/ticket/12061 and http://bugs.jqueryui.com/ticket/12063 and updated this PR to reference the first ticket. |
|
Looks good. |
|
👍 |
Fixes #12061 Closes gh-1538 Ref #7053 Ref jquery/api.jqueryui.com#256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref jquery/api.jqueryui.com#256
Ref #7053
I figured that we can keep it simple for this trivial change and not create separate unit test files.