Blind effect bugfix #563
Closed
Blind effect bugfix #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give us a reduced test case that shows the bug? I don't see anything wrong with the patch, but I'd like to know why we need it |
|
Sure thing, here it is (with latest jquery-ui build): http://rozwell.pl/jquery.blind-test/ And it's source: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="pl" lang="pl">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Blind effect test</title>
<script type="text/javascript" src="http://code.jquery.com/jquery-1.7.1.min.js"></script>
<script type="text/javascript" src="http://rozwell.pl/jquery.blind-test/jquery-ui.1.9pre.js"></script>
<script type="text/javascript">
$(function(){
var speed = 1200;
$("#logo").delay(500)
.hide("blind", {direction: "left"}, speed) // works
.show("blind", {direction: "left"}, speed) // works
.hide("blind", {direction: "right"}, speed) // fails
.show("blind", {direction: "right"}, speed) // fails
.hide("blind", {direction: "up"}, speed) // works
.show("blind", {direction: "up"}, speed) // works
.hide("blind", {direction: "down"}, speed) // fails
.show("blind", {direction: "down"}, speed) // fails
;
});
</script>
<style type="text/css">
#container {
position: absolute;
top: 100px;
left: 50%;
margin: 0 0 0 -400px;
width: 800px;
height: 400px;
background: #bbb;
}
#logo {
position: absolute;
background: url('http://rozwell.pl/jquery.blind-test/logo.gif') no-repeat center #1c1c1c;
left: 300px;
top: 100px;
width: 235px;
height: 55px;
}
.ui-effects-wrapper {
background: #f00 !important; /* will not be visible if everything works fine */
/* uncomment below for failing tests to see what happens with the logo */
/* overflow: visible !important; */
}
</style>
</head>
<body>
<div id="container">
<div id="logo"></div>
</div>
</body>
</html> |
|
Alright, makes sense. Merging. |
gnarf
pushed a commit
that referenced
this pull request
Jan 5, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't work well for me, especially when I had absolutely positioned elements.
I did only basic tests but it seems to be working fine now.