Skip to content

HTML syntax error on all jquery sites #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IsibisiDev opened this issue Nov 25, 2018 · 5 comments
Closed

HTML syntax error on all jquery sites #183

IsibisiDev opened this issue Nov 25, 2018 · 5 comments

Comments

@IsibisiDev
Copy link

I recently noticed an html syntax error on all jquery sites, including the QUnitJS site, contribute.jquery.org, learn.jquery.com and jquery.org to this line:
<!--[if IE 9 ]><html class="no-js ie ie9 lte9>"

@dmethvin
Copy link
Member

Yep,this looks like a real syntax error, although it would only occur on IE9 browsers.

@timmywil
Copy link
Member

Afaik, this is intentional to allow for adding ie classes to the HTML tag without the need for JavaScript. This is obviously less common these days with people leaving behind old IE, but it was a common trick back in the day. Point is, we may not want to drop it until we are ready to officially drop old IE on the jQuery sites.

@mgol
Copy link
Member

mgol commented Dec 13, 2018

The jQuery site looks broken on IE<9 already and has been that way for a long time. Conditional comments may be needed for IE 9 as well, though (IE 10+ doesn't support them).

@mgol
Copy link
Member

mgol commented Dec 13, 2018

@timmywil The issue here is real, though. There is a syntax error in the IE 9 part of the html tag as the class attribute ends with an unescaped >.

@IsibisiDev would you like to submit a PR? The code for that is most likely located in https://github.com/jquery/jquery-wp-content

@timmywil
Copy link
Member

Oh, I didn't notice the > inside the quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants