Skip to content

change http to https where applicable #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

change http to https where applicable #691

wants to merge 1 commit into from

Conversation

OmgImAlexis
Copy link

http://jquerymobile.com/themeroller redirects to https://themeroller.jquerymobile.com so I've updated that.

@agcolom
Copy link
Member

agcolom commented Jan 21, 2016

@OmgImAlexis Thank you very much for your PR. We do use tabs and not spaces, and it seems that in your PR all our tabs have been replaced by spaces (probably some setting in your text editor?). Could you please change the spaces back to tabs in your PR? Thank you.
@AurelioDeRosa @kswedberg, apart from the spacing issue, are we happy with the changes? thanks

@AurelioDeRosa
Copy link
Member

Apart from the spacing, it seems fine. I've tested almost every link updated and they still work.

@OmgImAlexis
Copy link
Author

@agcolom the main problem not only with this PR but with most of the PRs I've opened and had to close is that the jQuery org doesn't seem to have an editorconfig files in ANY of the repos. If you added that then it wouldn't matter what I used since it'd be changed on save since I have a plugin for editorconfig installed.

For ref: http://editorconfig.org/

@agcolom
Copy link
Member

agcolom commented Jan 22, 2016

@OmgImAlexis Oh,I see. Thanks for the details and link. I'll check with the @jquery/content team how we can best accommodate this.

@AurelioDeRosa
Copy link
Member

I'll submit a PR to add an .editorconfig file today so that we can refine and the merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants