Skip to content

Commit eeda11c

Browse files
danielhusargibson042
authored andcommitted
Core: Simplify and speed up .each
Closes jquerygh-1510
1 parent f6302b0 commit eeda11c

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

src/core.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -277,25 +277,20 @@ jQuery.extend({
277277

278278
// args is for internal usage only
279279
each: function( obj, callback, args ) {
280-
var value,
281-
i = 0,
280+
var i = 0,
282281
length = obj.length,
283282
isArray = isArraylike( obj );
284283

285284
if ( args ) {
286285
if ( isArray ) {
287286
for ( ; i < length; i++ ) {
288-
value = callback.apply( obj[ i ], args );
289-
290-
if ( value === false ) {
287+
if ( callback.apply( obj[ i ], args ) === false ) {
291288
break;
292289
}
293290
}
294291
} else {
295292
for ( i in obj ) {
296-
value = callback.apply( obj[ i ], args );
297-
298-
if ( value === false ) {
293+
if ( callback.apply( obj[ i ], args ) === false ) {
299294
break;
300295
}
301296
}
@@ -305,17 +300,13 @@ jQuery.extend({
305300
} else {
306301
if ( isArray ) {
307302
for ( ; i < length; i++ ) {
308-
value = callback.call( obj[ i ], i, obj[ i ] );
309-
310-
if ( value === false ) {
303+
if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) {
311304
break;
312305
}
313306
}
314307
} else {
315308
for ( i in obj ) {
316-
value = callback.call( obj[ i ], i, obj[ i ] );
317-
318-
if ( value === false ) {
309+
if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) {
319310
break;
320311
}
321312
}

0 commit comments

Comments
 (0)