Menu: Ignore clicks that don't occur on the anchor tag within a valid menu item.

scottgonzalez · scottgonzalez · commit f2873b6ebf42 · 2010-03-24T07:15:30.000-07:00
Fixes #5376 - Menu plugin fires select when border is clicked.
diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js
@@ -335,7 +335,7 @@ $.widget("ui.menu", {
 				"aria-activedescendant": "ui-active-menuitem"
 			})
 			.click(function( event ) {
-				if ( !$( event.target ).closest( ".ui-menu-item" ).length ) {
+				if ( !$( event.target ).closest( ".ui-menu-item a" ).length ) {
 					return;
 				}
 				// temporary

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ $.widget("ui.menu", {`
`335`	`335`	`"aria-activedescendant": "ui-active-menuitem"`
`336`	`336`	`})`
`337`	`337`	`.click(function( event ) {`
`338`		`- if ( !$( event.target ).closest( ".ui-menu-item" ).length ) {`
	`338`	`+ if ( !$( event.target ).closest( ".ui-menu-item a" ).length ) {`
`339`	`339`	`return;`
`340`	`340`	`}`
`341`	`341`	`// temporary`