fix(options): use filename mutated after instantiation (webpack-contrib#430)

lbennett-stacki · evilebottnawi · commit 0bacfac7ef4a · 2019-07-19T14:22:09.000+03:00
diff --git a/src/index.js b/src/index.js
@@ -124,7 +124,7 @@ class MiniCssExtractPlugin {
     this.options = Object.assign(
       {
         filename: DEFAULT_FILENAME,
-        moduleFilename: () => options.filename || DEFAULT_FILENAME,
+        moduleFilename: () => this.options.filename || DEFAULT_FILENAME,
         ignoreOrder: false,
       },
       options
diff --git a/test/cases/moduleFilenameMutableFilename/expected/mutated.css b/test/cases/moduleFilenameMutableFilename/expected/mutated.css
@@ -0,0 +1,4 @@
+body {
+  background: palegreen;
+}
+
diff --git a/test/cases/moduleFilenameMutableFilename/index.js b/test/cases/moduleFilenameMutableFilename/index.js
@@ -0,0 +1 @@
+import './style.css';
diff --git a/test/cases/moduleFilenameMutableFilename/style.css b/test/cases/moduleFilenameMutableFilename/style.css
@@ -0,0 +1,3 @@
+body {
+  background: palegreen;
+}
diff --git a/test/cases/moduleFilenameMutableFilename/webpack.config.js b/test/cases/moduleFilenameMutableFilename/webpack.config.js
@@ -0,0 +1,27 @@
+const Self = require('../../../');
+
+module.exports = {
+  entry: {
+    main: './index.js',
+  },
+  module: {
+    rules: [
+      {
+        test: /\.css$/,
+        use: [Self.loader, 'css-loader'],
+      },
+    ],
+  },
+  output: {
+    filename: '[name].js',
+  },
+  plugins: [
+    (() => {
+      const self = new Self({ filename: 'constructed.css' });
+
+      self.options.filename = 'mutated.css';
+
+      return self;
+    })(),
+  ],
+};

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ class MiniCssExtractPlugin {`
`124`	`124`	`this.options = Object.assign(`
`125`	`125`	`{`
`126`	`126`	`filename: DEFAULT_FILENAME,`
`127`		`- moduleFilename: () => options.filename \|\| DEFAULT_FILENAME,`
	`127`	`+ moduleFilename: () => this.options.filename \|\| DEFAULT_FILENAME,`
`128`	`128`	`ignoreOrder: false,`
`129`	`129`	`},`
`130`	`130`	`options`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +body {
 +  background: palegreen;
 +}
++