[CSV-140] QuoteMode.NON_NUMERIC doesn't work with CSVPrinter.printRecords(ResultSet)

garydgregory · garydgregory · commit ea5b3e0ba6e1 · 2014-11-10T03:06:47.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1637781 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -39,6 +39,7 @@
   </properties>
   <body>
     <release version="1.1" date="2014-11-dd" description="Feature and bug fix release">
+      <action issue="CSV-140" type="fix" dev="ggregory" due-to="Damjan Jovanovic">QuoteMode.NON_NUMERIC doesn't work with CSVPrinter.printRecords(ResultSet)</action>
       <action issue="CSV-131" type="add" dev="ggregory" due-to="Holger Stratmann">Save positions of records to enable random access</action>
       <action issue="CSV-130" type="fix" dev="ggregory" due-to="Sergei Lebedev">CSVFormat#withHeader doesn't work well with #printComment, add withHeaderComments(String...)</action>
       <action issue="CSV-128" type="fix" dev="ggregory">CSVFormat.EXCEL should ignore empty header names</action>
diff --git a/src/main/java/org/apache/commons/csv/CSVPrinter.java b/src/main/java/org/apache/commons/csv/CSVPrinter.java
@@ -512,7 +512,7 @@ public void printRecords(final ResultSet resultSet) throws SQLException, IOExcep
         }
         while (resultSet.next()) {
             for (int i = 1; i <= columnCount; i++) {
-                print(resultSet.getString(i));
+                print(resultSet.getObject(i));
             }
             println();
         }

Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ public void printRecords(final ResultSet resultSet) throws SQLException, IOExcep`
`512`	`512`	`}`
`513`	`513`	`while (resultSet.next()) {`
`514`	`514`	`for (int i = 1; i <= columnCount; i++) {`
`515`		`- print(resultSet.getString(i));`
	`515`	`+ print(resultSet.getObject(i));`
`516`	`516`	`}`
`517`	`517`	`println();`
`518`	`518`	`}`