tune up the autoWidth impl and docco how it's impl

so people can determine if it is worth it.


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@779586 13f79535-47bb-0310-9956-ffa450edef68

Author: jimjag

src/java/org/apache/commons/cli/HelpFormatter.java

@@ -140,7 +140,7 @@ public class HelpFormatter
     /**
      * Flag to determine if we try to determine terminal width
      */
-    public boolean autoWidth = false;
+    private boolean autoWidth = false;
 
     /**
      * Sets the 'width'.
@@ -702,7 +702,7 @@ private static String unixCmdOut(String program)
         String rstr;
         ByteArrayOutputStream sout = new ByteArrayOutputStream();
         try {
-            Process p = Runtime.getRuntime().exec(new String[] {"sh","-c",program});
+            Process p = Runtime.getRuntime().exec(new String[] {"/bin/sh","-c",program});
             in = p.getInputStream();
             while ((c = in.read()) != -1) {
                 sout.write(c);

xdocs/changes.xml

@@ -25,6 +25,9 @@
     <release version="1.3" date="in SVN">
       <action type="add" dev="jim" issue="CLI-166">
         HelpFormatter can now autodetect (if desired) terminal width under Unix.
+        This is done via setAutoWidth(true) and the actual terminal width determination
+        is done internally by calling "/bin/sh -c stty -a < /dev/null". If anything
+        fails, the defaultWidth is used.
       </action>
       <action type="add" dev="ebourg" issue="CLI-160">
         PosixParser now supports partial long options (--ver instead of --version)