Skip to content

Commit 5151ae8

Browse files
[css-view-transitions-1] Fix warnings, add issues for currently unfixable warnings (w3c#8005)
* Fix whitespace, markdown, and promise refs * Consistent rendering opportunity references * Create issues for things causing bikeshed warnings
1 parent b300cc4 commit 5151ae8

File tree

1 file changed

+30
-16
lines changed

1 file changed

+30
-16
lines changed

css-view-transitions-1/Overview.bs

+30-16
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Editor: Tab Atkins-Bittner, Google, http://xanthir.com/contact/, w3cid 42199
1313
Editor: Jake Archibald, Google, w3cid 76394
1414
Editor: Khushal Sagar, Google, w3cid 122787
1515
Abstract: This module defines the View Transition API, along with associated properties and pseudo-elements.
16+
Markup Shorthands: css no, markdown yes
1617
</pre>
1718

1819
<pre class=link-defaults>
@@ -21,6 +22,7 @@ spec:css-position-3; type:property
2122
text: inset-block-start
2223
text: inset-inline-start
2324
spec:css-shapes-3; type:function; text:rect()
25+
spec:webidl; type:interface; text:Promise
2426
</pre>
2527

2628
<style>
@@ -59,7 +61,7 @@ This spec describes the CSS and JS mechanics of the single-page transition API.
5961

6062
A key part of this API design is the view that an animated transition is an
6163
enhancement to a DOM change. Specifically, there are two components of the API:
62-
the DOM change, and the visual state animation.
64+
the DOM change, and the visual state animation.
6365

6466
In order for the user-agent to generate a set of snapshots prior to the DOM
6567
change, the API is designed to take the DOM change callback as part of the
@@ -484,7 +486,9 @@ callback UpdateDOMCallback = Promise<any> ();
484486

485487
1. Set |document|'s [=active DOM transition=] to |transition|.
486488

487-
Note: The process continues in [=perform an outgoing capture=] which is executed at the next [=rendering-opportunity=].
489+
Note: The process continues in [=perform an outgoing capture=] which is executed at the next [=rendering opportunity=].
490+
491+
Issue: Waiting on [html/8469](https://github.com/whatwg/html/pull/8468) to reference "rendering opportunity".
488492

489493
1. Return |transition|.
490494
</div>
@@ -639,10 +643,12 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi
639643

640644
Note: The aim is to prevent unintended DOM updates from being presented to the
641645
user after a cached snapshot for the elements has been captured. We wait for
642-
one rendering opportunity after prepare to present DOM mutations made by the
646+
one [=rendering opportunity=] after prepare to present DOM mutations made by the
643647
author before prepare to be presented to the user. This is also the content
644648
captured in snapshots.
645649

650+
Issue: Waiting on [html/8469](https://github.com/whatwg/html/pull/8468) to reference "rendering opportunity".
651+
646652
Note: These steps will be added to the [=update the rendering=] in the HTML spec.
647653
As such, the prose style is written to match other steps in that algorithm.
648654
</div>
@@ -739,6 +745,8 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi
739745
Note: A task is queued here because the texture read back in [=capturing the image=] may be async,
740746
although the render steps in the HTML spec act as if it's synchronous.
741747

748+
Issue: "DOM manipulation task source" doesn't link due to a [bikeshed bug](https://github.com/tabatkins/bikeshed/issues/2382).
749+
742750
1. If |transition|'s [=ViewTransition/phase=] is "`done`", then abort these steps.
743751

744752
Note: This happens if |transition| was [=skip the page transition|skipped=] before this point.
@@ -893,20 +901,26 @@ The {{ViewTransition/domUpdated}} [=getter steps=] are to return [=this's=] [=Vi
893901
To <dfn>update transition DOM</dfn> given a {{ViewTransition}} |transition|:
894902

895903
1. Let |document| be |transition|'s [=relevant global object's=] [=associated document=].
896-
897-
1. Let |hasActiveAnimations| be a boolean, initially false. For each [=page-transition pseudo-elements=]
898-
associated with |transition|:
899-
904+
905+
1. Let |hasActiveAnimations| be a boolean, initially false.
906+
907+
1. For each [=page-transition pseudo-elements=] associated with |transition|:
908+
900909
1. Let |element| be the [=page-transition pseudo-element=].
901-
902-
1. For each |animation| that contains at least one [=animation effect=]
903-
whose [=effect target=] is |element| and whose associated [=animation timeline=]
904-
is of type [=document timeline=], set |hasActiveAnimations| to true if any of the
905-
following conditions is true:
906-
907-
1. |animation| is in <a lt="paused play state">paused</a> or <a lt="running play state">running</a> state.
908-
909-
1. [=pending-animation-event-queue=] has any events associated with |animation|.
910+
911+
1. For each |animation| whose [=timeline=] is a [=document timeline=] associated with |document|,
912+
and contains at least one [=animation/associated effect=] whose [=effect target=] is |element|,
913+
set |hasActiveAnimations| to true if any of the following conditions is true:
914+
915+
Issue: The prose around "effect target" is incorrect, but [#8001](https://github.com/w3c/csswg-drafts/issues/8001) needs to land before it can be fixed.
916+
917+
- |animation|'s [=animation/play state=] is [=idle play state=] or [=running play state=].
918+
919+
Issue: These terms aren't linking due to [#8003](https://github.com/w3c/csswg-drafts/issues/8003).
920+
921+
- |document|'s [=pending animation event queue=] has any events associated with |animation|.
922+
923+
Issue: This prose isn't quite right, but it's blocked on [#8004](https://github.com/w3c/csswg-drafts/issues/8004).
910924

911925
1. If |hasActiveAnimations| is false:
912926

0 commit comments

Comments
 (0)