Skip to content

Commit efdbb69

Browse files
committed
Fix memory leaks
1 parent dbe4138 commit efdbb69

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lib/net.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -629,6 +629,9 @@ Socket.prototype.connect = function() {
629629
initSocket(self);
630630
if (self.fd) throw new Error('Socket already opened');
631631

632+
assert(!self._readWatcher);
633+
assert(!self._writeWatcher);
634+
632635
timers.active(this);
633636

634637
self._connecting = true; // set false in doConnect

src/node_io_watcher.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ static Handle<Value> IOAlloc(const Arguments& args) {
8484
static Handle<Value> IOFree(const Arguments& args) {
8585
HandleScope scope;
8686
ev_io *io = JSToAddress<ev_io>(args[0]);
87+
Persistent<Object>* obj_p = static_cast<Persistent<Object>*>(io->data);
88+
obj_p->Dispose();
89+
delete obj_p;
8790
delete io;
8891
return Undefined();
8992
}

0 commit comments

Comments
 (0)