Skip to content

Commit f58829a

Browse files
committed
fix: improve blog based on suggestions
1 parent ef60c16 commit f58829a

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

content/blog/entries/cc-search-accessibility-week3-4/contents.lr

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ pub_date: 2020-06-26
1616
body:
1717

1818
These are the second two weeks of my internship with CC. I am working on improving the accessibility of cc-search and internationalizing it as well.
19-
The internationalization work from the previous post is continued here and we also solve an interesting issue of translating strings from the store.
19+
The internationalization work from the previous post is continued here and we also solve an interesting issue of translating strings from the Vuex store.
2020

2121
During this period I removed all the hardcoded strings from the static pages which include:
2222

@@ -35,7 +35,7 @@ licenseTypes: [
3535
{ code: 'modification', name: 'Modify or adapt', checked: false },
3636
]
3737
```
38-
The code was used to store the licenses in the store in the oredered format. The challenge was to extract the name strings from each license while keeping the changes and dependencies to a minimum.
38+
The code was used to store the licenses in the store in the ordered format. The challenge was to extract the name strings from each license while keeping the changes and dependencies to a minimum.
3939
The code which we were using in the templates to load these strings was:
4040

4141
```
@@ -84,7 +84,7 @@ licenseTypes: [
8484
</label>
8585
```
8686

87-
The rest of the internationalization stuff was just basic string extractions and template modifications to accomodate the the translated strings.
87+
The rest of the internationalization stuff was string extractions and template modifications to accomodate the the translated strings.
8888
And we are done with these two weeks, we be back with another post after two weeks.
8989

9090
You can track the work done for these weeks through these PRs:

content/blog/entries/cc-search-accessibility-week5-6/contents.lr

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ pub_date: 2020-07-10
1616
body:
1717

1818
These are the fifth and sixth weeks of my internship with CC. I am working on improving the accessibility of cc-search and internationalizing it as well.
19-
This post contains yet another important aspect to be taken care of while internationalizing components, i.e. modifying tests to include the changes.
19+
This post contains yet another important aspect to be taken care of while internationalizing the Vue components, i.e. modifying tests to include the changes.
2020

2121
The components which were left are the two pages displaying the most content:
22-
1. Browse page
23-
2. ImageDetail page
22+
1. [Browse page](https://github.com/creativecommons/cccatalog-frontend/blob/develop/src/pages/BrowsePage.vue)
23+
2. [ImageDetail page](https://github.com/creativecommons/cccatalog-frontend/blob/develop/src/pages/PhotoDetailPage.vue)
2424

25-
But the above two pages too were handled similar to the remaining pages, special care had to be taken in case of ImageDetail page since there are too many components in different files.
25+
The above two pages too were handled similar to the remaining pages, special care had to be taken in case of ImageDetail page since there are too many components in different files.
2626
By this point we also have our json structure figured out, mostly and are ready to push the json for fetching further translations.
2727

2828
Now let's look at the modifications required in the tests. We generally use ```$t``` to access strings from the locales json, but this method/custom-component is not present in the testing vue instance, so we had to inject this method usin localVue and a custom i18n instance.
@@ -53,7 +53,7 @@ options = {
5353
};
5454
```
5555

56-
And now we are ready to render our component using these custom options with mocks for testing.
56+
Now we are ready to render our component using these custom options with mocks for testing.
5757

5858
And *drum rolls* we have successfully completed Internationalization of the complete cc search. Below are the images for some of the completed pages:
5959

content/blog/entries/cc-search-accessibility-week7-8/contents.lr

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ The aforementioned pages had the following accessiblity issues:
2525
2. Improper landmarks
2626
3. Improper aria-control nestings
2727
4. Some elements not being read by the screen-reader
28-
5. Contrast Issues(to be covered later)
28+
5. Color contrast Issues(to be covered later)
2929

3030
But before working I ran another set of audit tests to exactly pin-point these issues. I used [NVDA](https://www.nvaccess.org/) for running these audits.
3131
Lets go through the fixes one at a time.
@@ -45,7 +45,7 @@ These links did not contain any aria-label and were read as **cc link**. So the
4545
The next issue was of improper landmarks. Most of the pages had no **main** landmark and some had no **complimentary** or **region** landmarks even though they were required in those pages.
4646
These landmarks had to be added after the carefully scrutinising the pages in the audits.
4747

48-
The next issue was of improper aria-control nestings. This is actually interesting as it involves having some deeper understanding of the roles involved. So I will explain this in a little depth.
48+
The next issue was of improper aria-control nestings. This is interesting as it involves having some deeper understanding of the roles involved. So I will explain this in a little depth.
4949
The area where we had this issue was in feedback page. The code involved was:
5050

5151
```
@@ -117,7 +117,7 @@ After all these changes we had some increase in the accessibility scores(compute
117117
2. Search-Guide Page: 76 -> 97 | +23
118118
3. Feedback Page: 75 -> 97 | +22
119119

120-
Whoosh!! That was quite a lot. We are done with these two weeks for now. Hope seeing you in the next post as well.
120+
Whoosh!! That was quite a lot. We are done with these two weeks for now. Hope to see you in the next post as well.
121121

122122
You can track the work done for these weeks through these PRs:
123123

0 commit comments

Comments
 (0)