Skip to content

Commit 04e1aa0

Browse files
Merge pull request 4GeeksAcademy#103 from josemoracard/jose4-from-06-practicing-rules
fixed text in some exercises
2 parents 42b7cdc + e99823b commit 04e1aa0

File tree

15 files changed

+56
-56
lines changed

15 files changed

+56
-56
lines changed

exercises/06-Practicing-Rules/README.es.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@
88

99
3. Cambia el color del `h1` a rojo(`red`).
1010

11-
4. Haz todos los `h2` tengan subrayado.
11+
4. Haz que todos los `h2` tengan subrayado.
1212

1313
5. Agrega un `left padding` a todo el documento de `20px` para que sea más fácil de leer.
1414

15-
6. Agrega un fondo blanco semitransparente (`semi-transparent background 0.2`) al primer párrafo de "3 reasons you know you are learning" para que sea más fácil de leer (tienes que usar `rgba` para esto).
15+
6. Agrega un fondo blanco semitransparente (`semi-transparent background (0.2)`) al primer párrafo para que sea más fácil de leer (tienes que usar `rgba` para esto).
1616

1717
7. Luego aplica un `padding` de `5px` a todos los lados de ese párrafo.
1818

19-
8. Cambia el color del `anchor` "hover" a verde (`green`) y elimina el subrayado (tienes que colocar el anchor para probarlo).
19+
8. Cambia el color del `anchor` "hover" a verde (`green`) y elimina el subrayado (tienes que pasar el cursor encima del anchor para probarlo).
2020

2121
## El resultado debería ser algo como esto:
2222

exercises/06-Practicing-Rules/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ tutorial: "https://www.youtube.com/watch?v=4wguurrl-lU"
1616

1717
5. Add a `left padding` to the whole document of `20px` to make it easier to read.
1818

19-
6. Add a white `semi-transparent background (0.2)` to the `first paragraph` to make it easier to read (you have to use `rgba` for that) and type "3 reasons you know you are learning".
19+
6. Add a white `semi-transparent background (0.2)` to the `first paragraph` to make it easier to read (you have to use `rgba` for that).
2020

2121
7. Then apply a `padding` of `5px` to all sides of that paragraph.
2222

exercises/06-Practicing-Rules/index.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@
1212
<h1>The learning essay</h1>
1313
<h2>3 reasons you know you are learning</h2>
1414
<p id="id1">
15-
We are going to explain in this pharagraph the 3 most comon signs that you should look into yourself to recognize if you are learning.
15+
We are going to explain in this paragraph the 3 most common signs that you should look into yourself to recognize if you are learning.
1616
</p>
1717
<ol>
1818
<li>You are able to complete the exercises by yourself.</li>
19-
<li>You understand what the teacher is talking about</li>
20-
<li>Your are able to have conversations about the topic</li>
19+
<li>You understand what the teacher is talking about.</li>
20+
<li>You are able to have conversations about the topic.</li>
2121
</ol>
22-
<h2>3 reasons you know love what you are learning</h2>
22+
<h2>3 reasons you love what you are learning</h2>
2323
<ul>
2424
<li>Time passes fast.</li>
25-
<li>You are anxious to finish this excercise and start the next one.</li>
26-
<li>Is 12am and you don't want to go to sleep.</li>
25+
<li>You are anxious to finish this exercise and start the next one.</li>
26+
<li>It's 12am and you don't want to go to sleep.</li>
2727
</ul>
2828
<p>
2929
If you can't sleep, what better than watching videos of cats?

exercises/06-Practicing-Rules/tests.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe("All the styles should be applied", () => {
1111
let link = document.querySelector("link")
1212
let title = document.querySelector('title')
1313

14-
test("the background should match", () => {
14+
test("The background should match", () => {
1515
document.querySelector(
1616
"head"
1717
).innerHTML = `<style>${css.toString()}</style>`;
@@ -21,23 +21,23 @@ describe("All the styles should be applied", () => {
2121
`url(../../.learn/assets/background-vertical.jpg?raw=true) repeat-y`
2222
);
2323
});
24-
test("the font-family should be 'Times New Roman'", () => {
24+
test("The font-family should be 'Times New Roman'", () => {
2525
document.querySelector(
2626
"head"
2727
).innerHTML = `<style>${css.toString()}</style>`;
2828
let body = document.querySelector("body");
2929
let styles = window.getComputedStyle(body);
3030
expect(styles["font-family"].toLowerCase()).toBe("\"times new roman\"");
3131
});
32-
test("the padding-left should be '20px'", () => {
32+
test("The padding-left should be '20px'", () => {
3333
document.querySelector(
3434
"head"
3535
).innerHTML = `<style>${css.toString()}</style>`;
3636
let body = document.querySelector("body");
3737
let styles = window.getComputedStyle(body);
3838
expect(styles["padding-left"]).toBe("20px");
3939
});
40-
test("the font-family in the H1 Tag should be 'Courier'", () => {
40+
test("The font-family in the h1 tag should be 'Courier'", () => {
4141
document.querySelector(
4242
"head"
4343
).innerHTML = `<style>${css.toString()}</style>`;
@@ -46,7 +46,7 @@ describe("All the styles should be applied", () => {
4646
// get computed styles of any element you like
4747
expect(h1TagStyles["font-family"].toLowerCase()).toBe("\"courier\"");
4848
});
49-
test("the color in the H1 Tag should be 'red'", () => {
49+
test("The color in the h1 tag should be 'red'", () => {
5050
document.querySelector(
5151
"head"
5252
).innerHTML = `<style>${css.toString()}</style>`;
@@ -55,7 +55,7 @@ describe("All the styles should be applied", () => {
5555
// get computed styles of any element you like
5656
expect(h1TagStyles["color"]).toBe("red");
5757
});
58-
test("the text-decoration in the H2 Tag should be 'underline'", () => {
58+
test("the text-decoration in the h2 tag should be 'underline'", () => {
5959
document.querySelector(
6060
"head"
6161
).innerHTML = `<style>${css.toString()}</style>`;
@@ -64,7 +64,7 @@ describe("All the styles should be applied", () => {
6464
let h2TagStyles = window.getComputedStyle(h2Tag);
6565
expect(h2TagStyles["text-decoration"]).toBe("underline");
6666
});
67-
test("the padding in the #id1 Tag should be '5px'", () => {
67+
test("The padding in the #id1 tag should be '5px'", () => {
6868
document.querySelector(
6969
"head"
7070
).innerHTML = `<style>${css.toString()}</style>`;
@@ -74,7 +74,7 @@ describe("All the styles should be applied", () => {
7474
expect(idTagStyles["padding"]).toBe("5px");
7575
});
7676

77-
test("The a hover underline should be removed", () => {
77+
test("The a:hover underline should be removed", () => {
7878
document.querySelector(
7979
"head"
8080
).innerHTML = `<style>${css.toString()}</style>`;
@@ -88,7 +88,7 @@ describe("All the styles should be applied", () => {
8888
expect(orangeHoverSelector).toBe("none");
8989
});
9090

91-
test("The a hover color should be green", () => {
91+
test("The a:hover color should be green", () => {
9292
document.querySelector(
9393
"head"
9494
).innerHTML = `<style>${css.toString()}</style>`;
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
1-
# `07` Reglas Muy Especificas
1+
# `07` Reglas Muy Específicas
22

33
## **Importante:**
44

5-
En este ejercicio, puedes agregar tu código solo arriba del **READ ONLY BLOCK** del código, puedes agregar tantas líneas como desees, pero siempre arriba.
5+
En este ejercicio, puedes agregar tu código solo arriba del **READ-ONLY BLOCK** del código, puedes agregar tantas líneas como desees, pero siempre arriba.
66

77
## 📝 Instrucciones:
88

9-
1. Establece el color de texto `ul` a rojo (`red`) (anula los conflictos siendo más específico).
9+
1. Establece el color de texto `ul li` a rojo (`red`) (anula los conflictos siendo más específico).
1010

1111
2. Establece el color de fondo (`background-color`) del segundo `li` del `ol` a verde (`green`) (no uses el selector #id ni el .class).
1212

13-
3. Haz que las filas impares de las tablas tengan fondo amarillo usando `tr:nth-child`.
13+
3. Haz que las filas impares de la tabla tengan fondo amarillo usando `tr:nth-child`.
1414

1515

1616
![Example Image](../../.learn/assets/07-1.png?raw=true)
1717
>Importante: **NO** debes modificar el archivo index.html
1818
19-
## :bulb: Pista:
19+
## 💡 Pista:
2020

21-
1. El atributo `!important` ayuda a sobreescribir stilos.
21+
1. El atributo `!important` ayuda a sobreescribir estilos.

exercises/07-Very-Specific-Rules/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ tutorial: "https://www.youtube.com/watch?v=2YkLDRZFk40"
66

77
# **Important:**
88

9-
In this exercise, you can add your code only above the **READ ONLY BLOCK** of the code, you can add as many lines as you want, but always above.
9+
In this exercise, you can add your code only above the **READ-ONLY BLOCK** of the code, you can add as many lines as you want, but always above.
1010

1111
## 📝 Instructions:
1212

@@ -19,8 +19,8 @@ In this exercise, you can add your code only above the **READ ONLY BLOCK** of th
1919

2020

2121
![Example Image](../../.learn/assets/07-1.png?raw=true)
22-
>Important: You should **NOT** modify the index.html file
22+
>Important: You should **NOT** modify the index.html file.
2323
2424
## :bulb: Hint:
2525

26-
1. The `!important` attribute helps to override over other attributes.
26+
1. The `!important` attribute helps to override other attributes.

exercises/07-Very-Specific-Rules/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@
1010
<h1>The learning essay</h1>
1111
<h2>3 reasons you know you are learning</h2>
1212
<p id="id1">
13-
We are going to explain in this pharagraph the 3 most comon signs that you should look into yourself to recognize if you are learning.
13+
We are going to explain in this paragraph the 3 most common signs that you should look into yourself to recognize if you are learning.
1414
</p>
1515
<ol>
1616
<li>You are able to complete the exercises by yourself.</li>
1717
<li>You understand what the teacher is talking about</li>
18-
<li>Your are able to have conversations about the topic</li>
18+
<li>You are able to have conversations about the topic</li>
1919
</ol>
2020
<h2>3 reasons you know love what you are learning</h2>
2121
<ul>
2222
<li>Time passes fast.</li>
23-
<li>You are anxious to finish this excercise and start the next one.</li>
24-
<li>Is 12am and you don't want to go to sleep.</li>
23+
<li>You are anxious to finish this exercise and start the next one.</li>
24+
<li>It's 12am and you don't want to go to sleep.</li>
2525
</ul>
2626
<p>
2727
If you can't sleep, what better than watching videos of cats?

exercises/07-Very-Specific-Rules/solution.hide.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ tr:nth-child(odd) {
1212
background: yellow;
1313
}
1414

15-
/*********** READ ONLY BLOCK ******
15+
/*********** READ-ONLY BLOCK ******
1616
You CANNOT UPDATE anything from here on,
17-
only add lines of code on top of this lines
17+
only add lines of code on top of these lines
1818
**/
1919

2020
body {

exercises/07-Very-Specific-Rules/styles.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/** Insert your code here **/
22

3-
/*********** READ ONLY BLOCK ******
3+
/********** READ-ONLY BLOCK ******
44
You CANNOT UPDATE anything from here on,
5-
only add lines of code on top of this lines
5+
only add lines of code on top of these lines
66
**/
77

88
body {
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
# `08` Imagen Redondeada
22

3-
Muchos sitios web usan imágenes de perfil redondeadas ¡una técnica que realmente hace que un sitio web sea más hermoso!
3+
Muchos sitios web usan imágenes de perfil redondeadas, ¡una técnica que realmente hace que un sitio web sea más hermoso!
44

55
La forma obvia de crear una imagen de perfil redondeada es crear una etiqueta de imagen y aplicar un `border-radius: 100%`.
66

7-
El problema con este enfoque es que solo funciona para imágenes cuadradas... Las imágenes de perfil generalmente tienen diferente altura y ancho no se verán como un círculo, se verán como óvalos:
7+
El problema con este enfoque es que solo funciona para imágenes cuadradas... Las imágenes de perfil generalmente tienen diferente altura y ancho, no se verán como un círculo, se verán como óvalos:
88

99
![Example Image](../../.learn/assets/08-1.png?raw=true)
1010

1111
## 📝 Instrucciones:
1212

1313
1. Usa `border-radius`.
1414

15-
2. Adicionalmente a `border-radius`, tenemos que también utilizar la propiedad `object-fit`, [aqui hay una explicación](https://www.loom.com/share/15186e456dfd4741887997af40325721).
15+
2. Además de `border-radius`, tenemos que utilizar también la propiedad `object-fit`, [aquí hay una explicación](https://www.loom.com/share/15186e456dfd4741887997af40325721).
1616

1717
## 💡 Pista:
1818

19-
+ Si la imagen es más grande que su contenedor y quieres centrarla o enfocarte en una zona en particular puedes utilizar `object-position`.
19+
+ Si la imagen es más grande que su contenedor y quieres centrarla o enfocarte en una zona en particular, puedes utilizar `object-position`.
2020

21-
+ En este articulo puedes leer más [sobre la propiedad object fit](https://css-tricks.com/on-object-fit-and-object-position/)
21+
+ En este artículo puedes leer más [sobre la propiedad object fit](https://css-tricks.com/on-object-fit-and-object-position/).
2222

23-
+ Adicionalmente, puedes [leer la documentación de object-position](https://developer.mozilla.org/en-US/docs/Web/CSS/object-position) y [la documentación de object-fit](https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit)
23+
+ Adicionalmente, puedes [leer la documentación de object-position](https://developer.mozilla.org/en-US/docs/Web/CSS/object-position) y [la documentación de object-fit](https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit).

0 commit comments

Comments
 (0)