Skip to content

Commit 79f5790

Browse files
Merge pull request 4GeeksAcademy#96 from josemoracard/jose11-04.1-combined-rules
fixed text 04.1-combined-rules
2 parents 7ca544a + 7ff6e8b commit 79f5790

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

exercises/04.1-Combined-Rules/README.es.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Los archivos CSS ocupan espacio en tu servidor y también tardan en descargarse (como todo); es otro documento de texto que el navegador debe descargar antes de mostrar la página, por lo que es importante mantener el documento CSS lo más pequeño posible.
44

5-
Una forma de hacerlo es combinando varias propiedades en una, como con "border":
5+
Una forma de hacerlo es combinando varias propiedades en una, como con `border`:
66

77
```css
88
border-color: black;
@@ -16,7 +16,7 @@ Las propiedades de border se pueden consolidar en una sola línea así:
1616
border: black 1px solid;
1717
```
1818

19-
# 📝 Instrucciones:
19+
## 📝 Instrucciones:
2020

2121

2222
1. Combina las 4 reglas de padding en una sola utilizando la regla `padding`.
@@ -25,7 +25,7 @@ border: black 1px solid;
2525

2626
*El `background-size` no se puede combinar, los navegadores aún no lo admiten.*
2727

28-
## Pista:
28+
## 💡 Pista:
2929

30-
- Como usar el background-size: http://lmgtfy.com/?q=css+background
31-
- Como usar el padding: http://lmgtfy.com/?q=css+padding
30+
- mo usar el background-size: http://lmgtfy.com/?q=css+background
31+
- mo usar el padding: http://lmgtfy.com/?q=css+padding

exercises/04.1-Combined-Rules/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@ tutorial: "https://youtu.be/watch?v=uQS5QeEE-B4"
44

55
# `04.1` Combined Rules
66

7-
CSS files take space on your server and also take time to download (like everything); it is yet another text document that the browser has to download before rendering the page, which is why is important to keep the CSS document as small as possible.
7+
CSS files take up space on your server and also take time to download (like everything); it is yet another text document that the browser has to download before rendering the page, which is why it's important to keep the CSS document as small as possible.
88

9-
One way to do that is by combining several properties into one such as with `border`:
9+
One way to do that is by combining several properties into one, such as with `border`:
1010

1111
```css
1212
border-color: black;
1313
border-style: solid;
1414
border-width: 1px;
1515
```
1616

17-
Border's properties can be consolidated into a single line as:
17+
Border's properties can be consolidated into a single line like this:
1818

1919
```css
2020
border: black 1px solid;
@@ -24,11 +24,11 @@ border: black 1px solid;
2424

2525
1. Combine the 4 padding rules into just one using the `padding` rule.
2626

27-
2. Combine the all background rules, but the `background-size`, into just one line using the `background:` rule.
27+
2. Combine all background rules, but the `background-size`, into just one line using the `background:` rule.
2828

2929
*The `background-size` cannot be combined, the browsers don't support it yet.*
3030

31-
## Hint:
31+
## 💡 Hint:
3232

3333
- How to use the background-size: http://lmgtfy.com/?q=css+background
3434

exercises/04.1-Combined-Rules/tests.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ describe("All the styles should be applied", ()=> {
1111
const link = document.querySelector("link");
1212
const title = document.querySelector('title');
1313

14-
test("The body tag should not contains any inline style", ()=> {
14+
test("The body tag should not contain any inline style", ()=> {
1515
document.querySelector(
1616
"head"
1717
).innerHTML = `<style>${css.toString()}</style>`;
1818
let emptyBodyInlineStyle = {};
1919
expect(body.style._values).toEqual(emptyBodyInlineStyle);
2020
});
2121

22-
test("the width should be '50px'", ()=> {
22+
test("The width should be '50px'", ()=> {
2323
// get computed styles of any element you like
2424
document.querySelector(
2525
"head"
@@ -37,7 +37,7 @@ describe("All the styles should be applied", ()=> {
3737
expect(orangeHoverSelector).toBe('50px');
3838
});
3939

40-
test("the height should be '50px'", ()=> {
40+
test("The height should be '50px'", ()=> {
4141
// get computed styles of any element you like
4242
document.querySelector(
4343
"head"
@@ -55,7 +55,7 @@ describe("All the styles should be applied", ()=> {
5555
expect(orangeHoverSelector).toBe('50px');
5656
});
5757

58-
test("the background-size should be contain", ()=> {
58+
test("The background-size should be 'contain'", ()=> {
5959
document.querySelector(
6060
"head"
6161
).innerHTML = `<style>${css.toString()}</style>`;
@@ -72,7 +72,7 @@ describe("All the styles should be applied", ()=> {
7272
expect(orangeHoverSelector).toBe('contain');
7373
});
7474

75-
test("the background should include the shorthand property", ()=> {
75+
test("The background should include the shorthand property", ()=> {
7676
document.querySelector(
7777
"head"
7878
).innerHTML = `<style>${css.toString()}</style>`;
@@ -102,7 +102,7 @@ describe("All the styles should be applied", ()=> {
102102
expect(orangeHoverSelector).toContain('url(https://github.com/4GeeksAcademy/css-tutorial-exercises-course/blob/3a2d1dd03f58167a5a4894155af2d3aa4d41d647/.learn/assets/baby.jpg?raw=true)');
103103
});
104104

105-
test("the padding should include the shorthand property in the right order (top, right, bottom, left)", ()=> {
105+
test("The padding should include the shorthand property in the right order (top, right, bottom, left)", ()=> {
106106
document.querySelector(
107107
"head"
108108
).innerHTML = `<style>${css.toString()}</style>`;

0 commit comments

Comments
 (0)