Skip to content

Commit b50a868

Browse files
Merge pull request 4GeeksAcademy#102 from josemoracard/jose3-from-04.2-apply-several-classes
fixed text in some exercises
2 parents 24ec581 + ab05db4 commit b50a868

File tree

10 files changed

+19
-17
lines changed

10 files changed

+19
-17
lines changed

exercises/04.2-Apply-several-classes/README.es.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Vamos a usar clases y aplicarlas al mismo elemento `<div>`.
77
<div class="card spades">9</div>
88
```
99

10-
La clase `card` contiene las reglas de estilo para hacer que el div se vea como una carta: bordes, ancho, etc.
10+
La clase `card` contiene las reglas de estilo para hacer que el div se vea como una carta: bordes, ancho, alto, etc.
1111

1212
La clase `spades` contiene las reglas de estilo requeridas para convertir la carta a la pinta de picas (negra con el símbolo de picas).
1313

exercises/04.2-Apply-several-classes/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ We are going to use two classes and apply them to the same `<div>` element.
1212
<div class="card spades">9</div>
1313
```
1414

15-
The class `card` contains the styling rules to make the div look like a card: Borders, Height, Width, etc.
15+
The class `card` contains the styling rules to make the div look like a card: borders, height, width, etc.
16+
1617
The class `spades` contains the styling rules needed to make the card turn into a spades suite (black and with a spades symbol).
1718

1819
There are two possible suite classes you can apply to the html element to make it look like a real poker card.

exercises/04.3-id-Selector/README.es.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ También puedes seleccionar un elemento por su `#id` y aplicarle estilos.
1010
}
1111
```
1212

13-
Usa la propiedad `id` del elemento HTML para seleccionarlo. Los `id` deben ser únicos, solo un elemento puede tener la misma `id`.
13+
Usa la propiedad `id` del elemento HTML para seleccionarlo. Los `id` deben ser únicos, así que no uses el mismo `id` en más de un elemento.
1414

1515
*La etiqueta HTML con `id="small"` tendrá un font-size de `9px`.*
1616

exercises/04.3-id-Selector/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ You can also select an element by `#id` and apply styles to it.
1414
}
1515
```
1616

17-
Use the `id` property of the HTML element to select it. `Ids` should be unique, only one element must have the same ìd`.
17+
Use the `id` property of the HTML element to select it. `ids` should be unique, don't use the same `id` on more than one element.
1818

19-
*The html tag with the `id="small"` will have a font-size of `9px`.*
19+
*The HTML tag with the `id="small"` will have a font-size of `9px`.*
2020

2121
## 📝 Instructions:
2222

exercises/04.3-id-Selector/test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ test("There should be a span tag", () => {
1212
expect(span).toBeTruthy()
1313
});
1414

15-
test("The span tag should have id 'button1'", () => {
15+
test("The span tag should have the id 'button1'", () => {
1616
expect(span).toBeTruthy();
1717
let id = span.id
1818
expect(id).toBeTruthy();
@@ -34,4 +34,4 @@ test("You should not change the existing head tag elements", () => {
3434

3535
const href = link.getAttribute("href");
3636
expect(href).toBe('./styles.css');
37-
});
37+
});
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# `05` Especificidad
22

3-
Al crear un documento CSS, debe comenzar desde el selector más genérico y terminar con el más específico, esa es la forma en que funciona CSS.
3+
Al crear un documento CSS, se debe comenzar desde el selector más genérico y terminar con el más específico, esa es la forma en que funciona CSS.
44

5-
Se trata del nivel de especificidad. Si especificas que tu `div` con `id="thirditem"` tiene un fondo (`background-color`) azul (`blue`), y más adelante en el documento especificas que todos los `divs` tendrán un fondo amarillo (`yellow`), `#thirditem` mantendrá su fondo azul (`blue`). ¡y punto!
5+
Se trata del nivel de **especificidad**. Si especificas que tu `div` con `id="thirditem"` tiene un fondo (`background-color`) azul (`blue`), y más adelante en el documento especificas que todos los `divs` tendrán un fondo amarillo (`yellow`), `#thirditem` mantendrá su fondo azul (`blue`). ¡Y punto!
66

77

88
*Porque cuanto más específico, más prioridad tiene.*
@@ -13,4 +13,4 @@ Se trata del nivel de especificidad. Si especificas que tu `div` con `id="thirdi
1313

1414
## 💡 Pista:
1515

16-
+ Puedes usar la anotación **!important** : https://css-tricks.com/when-using-important-is-the-right-choice/
16+
+ Puedes usar la anotación **!important** : https://css-tricks.com/when-using-important-is-the-right-choice/

exercises/05-Specificity/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ tutorial: "https://www.youtube.com/watch?v=3JxXkhxyAnI"
77
When creating a CSS document, you need to start from the most generic selectors and end with the most specific ones, that is the way CSS works.
88

99

10-
It's all about the level of Specificity. If you specify that your `div` with `id="thirditem` has a yellow background, and later in the document you specify that all `divs` will have blue background, `#thirditem` will keep his yellow background. punto!
10+
It's all about the level of **specificity**. If you specify that your `div` with `id="thirditem` has a yellow background, and later in the document you specify that all `divs` will have blue background, `#thirditem` will keep his yellow background. punto!
1111

1212
*Because the more specific, the more priority it has.*
1313

14-
## 📝 Instrucciones:
14+
## 📝 Instructions:
1515

16-
1. Override the `background` of `#thirditem` without deleting any css code, simply append to the css a more specific rule at the end of the document to override the background-color to green.
16+
1. Override the `background` of `#thirditem` without deleting any CSS code, simply append to the CSS a more specific rule at the end of the document to override the background-color to green.
1717

1818

19-
### 💡 Hint:
19+
## 💡 Hint:
2020

2121
You can use the **!important** annotation:
2222
https://css-tricks.com/when-using-important-is-the-right-choice/

exercises/05-Specificity/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<li>My first item of the list</li>
1212
<li>My second item of the list</li>
1313
<li id="thirditem">My third item of the list</li>
14-
<li>My forth item of the list</li>
14+
<li>My fourth item of the list</li>
1515
<li>My fifth item of the list</li>
1616
</ul>
1717
</body>

exercises/05-Specificity/solution.hide.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ ul li {
55
li + #thirditem {
66
background: yellow;
77
}
8-
/****** DON NOT EDIT ANYTHING ABOVE THIS LINE ****/
8+
/**** DO NOT EDIT ANYTHING ABOVE THIS LINE ****/
9+
910
#thirditem {
1011
background: green !important;
1112
}

exercises/05-Specificity/styles.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ ul li {
55
li + #thirditem {
66
background: yellow;
77
}
8-
/****** DON NOT EDIT ANYTHING ABOVE THIS LINE ****/
8+
/**** DO NOT EDIT ANYTHING ABOVE THIS LINE ****/

0 commit comments

Comments
 (0)