Skip to content

Commit f2e3e22

Browse files
RobinMalfaitadamwathan
authored andcommitted
make the cloning of the rule in the lookup table lazy
We create a big lookup table so that we can lookup the nodes by its utilityName. This is used inside the recursive `@apply` code. This big lookup table will clone every single rule and put it in, however we don't need to clone everything! We are only interested in the rules that have been actually applied. This way we make the cloning of the rule lazy and only when we use this exact rule. There is an additional performace "issue" though: When we read the same rule multiple times, it will clone every time you read from that object. We could add additional memoization stuff, but so far it doesn't seem to be the bottleneck. Therefore I've added a perf todo just to leave a mark when this becomes the bottleneck.
1 parent 5564e0b commit f2e3e22

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/flagged/applyComplexClasses.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,11 @@ function buildUtilityMap(css) {
8989
index,
9090
utilityName,
9191
classPosition: i,
92-
rule: rule.clone({ parent: rule.parent }),
92+
get rule() {
93+
// TODO: #perf every time we "read" this value we will create a copy.
94+
// Is this an issue?
95+
return rule.clone({ parent: rule.parent })
96+
},
9397
})
9498
index++
9599
})

0 commit comments

Comments
 (0)