Skip to content

Commit ee83c37

Browse files
fnagelscottgonzalez
authored andcommitted
Calendar: Remove option method overwrite
1 parent 3289158 commit ee83c37

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

tests/unit/calendar/calendar_methods.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ test( "valueAsDate", function() {
5555
var minDate, maxDate, dateAndTimeToSet, dateAndTimeClone,
5656
element = $( "#calendar" ).calendar(),
5757
date1 = new Date( 2008, 6 - 1, 4 ),
58-
date2 = new Date();
58+
date2;
5959

6060
element.calendar( "valueAsDate", new Date( 2014, 0, 1 ) );
6161
ok( element.find( "a[data-timestamp]:first" ).hasClass( "ui-state-active" ), "First day marked as selected" );
@@ -64,7 +64,7 @@ test( "valueAsDate", function() {
6464
element.calendar( "destroy" );
6565

6666
element.calendar();
67-
TestHelpers.calendar.equalsDate( element.calendar( "valueAsDate" ), date2, "Set date - default" );
67+
equal( element.calendar( "valueAsDate" ), null, "Set date - default" );
6868

6969
element.calendar( "valueAsDate", date1 );
7070
TestHelpers.calendar.equalsDate(element.calendar( "valueAsDate" ), date1, "Set date - 2008-06-04" );

ui/calendar.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ return $.widget( "ui.calendar", {
486486
if ( arguments.length ) {
487487
this._setOption( "value", value );
488488
} else {
489-
return this.option( "value" );
489+
return this.options.value;
490490
}
491491
},
492492

@@ -519,20 +519,14 @@ return $.widget( "ui.calendar", {
519519
.empty();
520520
},
521521

522-
option: function( key ) {
523-
if ( arguments.length === 0 || ( arguments.length === 1 && key === "value" ) ) {
524-
this.options.value = this.date.selectedDate();
525-
}
526-
527-
return this._superApply( arguments );
528-
},
529-
530522
_setOption: function( key, value ) {
531523
if ( key === "value" ) {
532524
if ( this._isValid( value ) ) {
533525
this.date.setTime( value.getTime() ).select();
526+
this._super( key, value );
534527
this.refresh();
535528
}
529+
return;
536530
}
537531

538532
if ( key === "max" || key === "min" ) {

0 commit comments

Comments
 (0)