Skip to content

Commit bd5fccc

Browse files
acustiNV
authored andcommitted
Coerce value param to string in CSSStyleDeclaration#setProperty (NV#82)
Coerce setProperty's value to string, fix NV#81
1 parent c82ca18 commit bd5fccc

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/CSSStyleDeclaration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ CSSOM.CSSStyleDeclaration.prototype = {
5151
this[this.length] = name;
5252
this.length++;
5353
}
54-
this[name] = value;
54+
this[name] = value + "";
5555
this._importants[name] = priority;
5656
},
5757

spec/CSSStyleDeclaration.spec.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,13 @@ describe('CSSStyleDeclaration', function() {
2929
}
3030
});
3131

32-
expect(d.cssText).toBe('color: purple; width: 128px !important;');
32+
d.setProperty('opacity', 0);
33+
34+
expect(d.cssText).toBe('color: purple; width: 128px !important; opacity: 0;');
3335

3436
expect(d.getPropertyValue('color')).toBe('purple');
3537
expect(d.getPropertyValue('width')).toBe('128px');
38+
expect(d.getPropertyValue('opacity')).toBe('0');
3639
expect(d.getPropertyValue('position')).toBe('');
3740

3841
expect(d.getPropertyPriority('color')).toBe('');
@@ -41,6 +44,7 @@ describe('CSSStyleDeclaration', function() {
4144

4245
d.setProperty('color', 'green');
4346
d.removeProperty('width');
47+
d.removeProperty('opacity');
4448

4549
expect(d.cssText).toBe('color: green;');
4650
});

0 commit comments

Comments
 (0)