Merge pull request #1111 from rantianhua/master

refactor: stop foreground service after all tasks finished in Android O

Author: Jacksgong

library/src/main/java/com/liulishuo/filedownloader/FileDownloadList.java

@@ -177,6 +177,11 @@ public boolean remove(final BaseDownloadTask.IRunningTask willRemoveDownload,
         boolean succeed;
         synchronized (mList) {
             succeed = mList.remove(willRemoveDownload);
+            if (succeed && mList.size() == 0) {
+                if (FileDownloadServiceProxy.getImpl().isRunServiceForeground()) {
+                    FileDownloader.getImpl().stopForeground(true);
+                }
+            }
         }
         if (FileDownloadLog.NEED_LOG) {
             if (mList.size() == 0) {
@@ -206,7 +211,6 @@ public boolean remove(final BaseDownloadTask.IRunningTask willRemoveDownload,
                 default:
                     // ignored
             }
-
         } else {
             FileDownloadLog.e(this, "remove error, not exist: %s %d", willRemoveDownload,
                     removeByStatus);

library/src/main/java/com/liulishuo/filedownloader/FileDownloadServiceProxy.java

@@ -149,4 +149,9 @@ public boolean clearTaskData(int id) {
     public void clearAllTaskData() {
         handler.clearAllTaskData();
     }
+
+    @Override
+    public boolean isRunServiceForeground() {
+        return handler.isRunServiceForeground();
+    }
 }

library/src/main/java/com/liulishuo/filedownloader/FileDownloadServiceSharedTransmit.java

@@ -44,6 +44,8 @@ class FileDownloadServiceSharedTransmit implements
 
     private static final Class<?> SERVICE_CLASS = SharedMainProcessService.class;
 
+    private boolean runServiceForeground = false;
+
     @Override
     public boolean start(String url, String path, boolean pathAsDirectory,
                          int callbackProgressTimes,
@@ -147,8 +149,10 @@ public void bindStartByContext(Context context, Runnable connectedRunnable) {
         if (FileDownloadUtils.needMakeServiceForeground(context)) {
             if (FileDownloadLog.NEED_LOG) FileDownloadLog.d(this, "start foreground service");
             context.startForegroundService(i);
+            runServiceForeground = true;
         } else  {
             context.startService(i);
+            runServiceForeground = false;
         }
     }
 
@@ -177,6 +181,7 @@ public void stopForeground(boolean removeNotification) {
         }
 
         handler.stopForeground(removeNotification);
+        runServiceForeground = false;
     }
 
     @Override
@@ -206,6 +211,11 @@ public void clearAllTaskData() {
         handler.clearAllTaskData();
     }
 
+    @Override
+    public boolean isRunServiceForeground() {
+        return runServiceForeground;
+    }
+
     private FDServiceSharedHandler handler;
 
     @Override

library/src/main/java/com/liulishuo/filedownloader/FileDownloadServiceUIGuard.java

@@ -248,6 +248,8 @@ public void stopForeground(boolean removeNotification) {
             getService().stopForeground(removeNotification);
         } catch (RemoteException e) {
             e.printStackTrace();
+        } finally {
+            runServiceForeground = false;
         }
     }
 

library/src/main/java/com/liulishuo/filedownloader/IFileDownloadServiceProxy.java

@@ -61,4 +61,6 @@ boolean start(final String url, final String path, final boolean pathAsDirectory
     boolean clearTaskData(int id);
 
     void clearAllTaskData();
+
+    boolean isRunServiceForeground();
 }

library/src/main/java/com/liulishuo/filedownloader/services/BaseFileServiceUIGuard.java

@@ -45,6 +45,7 @@ public abstract class BaseFileServiceUIGuard<CALLBACK extends Binder, INTERFACE
     private final CALLBACK callback;
     private volatile INTERFACE service;
     private final Class<?> serviceClass;
+    protected boolean runServiceForeground = false;
 
     private final HashMap<String, Object> uiCacheMap = new HashMap<>();
 
@@ -158,8 +159,10 @@ public void bindStartByContext(final Context context, final Runnable connectedRu
         if (FileDownloadUtils.needMakeServiceForeground(context)) {
             if (FileDownloadLog.NEED_LOG) FileDownloadLog.d(this, "start foreground service");
             context.startForegroundService(i);
+            runServiceForeground = true;
         } else {
             context.startService(i);
+            runServiceForeground = false;
         }
     }
 
@@ -185,13 +188,20 @@ public void unbindByContext(final Context context) {
         context.stopService(i);
     }
 
+    @Override
+    public boolean isRunServiceForeground() {
+        return runServiceForeground;
+    }
+
     public void startService(final Context context) {
         Intent i = new Intent(context, serviceClass);
         if (FileDownloadUtils.needMakeServiceForeground(context)) {
             if (FileDownloadLog.NEED_LOG) FileDownloadLog.d(this, "start foreground service");
             context.startForegroundService(i);
+            runServiceForeground = true;
         } else {
             context.startService(i);
+            runServiceForeground = false;
         }
     }