default flex-basis is 0% not auto. fixes #19

Author: luisrudge

bugs/bug4.js

@@ -1,19 +1,14 @@
 var postcss = require('postcss');
 
-function shouldSetAutoBasis(basisValue) {
-    return !basisValue || !basisValue.length;
-}
-
 function shouldSetZeroBasis(basisValue) {
+    if (!basisValue) {
+        return false;
+    }
     return basisValue === '0' || basisValue.replace(/\s/g, '') === '0px';
 }
 
 function properBasis(basis) {
-    if (shouldSetAutoBasis(basis))
-    {
-        return 'auto';
-    }
-    if (shouldSetZeroBasis(basis)){
+    if (shouldSetZeroBasis(basis)) {
         return '0%';
     }
     return basis;
@@ -24,7 +19,7 @@ module.exports = function(decl) {
         var values = postcss.list.space(decl.value);
         var flexGrow = values[0];
         var flexShrink = values[1];
-        var flexBasis = values[2];
+        var flexBasis = values[2] || '0%';
         decl.value = flexGrow + ' ' + (flexShrink || '1') + ' ' + properBasis(flexBasis);
     }
 };

specs/bug3Spec.js

@@ -9,7 +9,7 @@ describe('bug 3', function() {
     describe('does nothing', function() {
         it('when not display: flex', function(done) {
             var input = 'a{flex: 0;}';
-            var output = 'a{flex: 0 1 auto;}';
+            var output = 'a{flex: 0 1 0%;}';
             test(input, output, {}, done);
         });
         it('when no min-height is set', function(done) {

specs/bug4Spec.js

@@ -3,21 +3,21 @@ var test = require('./test');
 describe('bug 4', function() {
     it('set auto for default flex-basis property and flex-shrink in flex shorthand', function(done) {
         var input = 'div{flex: 1;}';
-        var output = 'div{flex: 1 1 auto;}';
+        var output = 'div{flex: 1 1 0%;}';
         test(input, output, {}, done);
     });
     it('set flex-basis === auto when flex-basis is not set and flex-shrink is specified', function(done) {
         var input = 'div{flex: 1 1;}';
-        var output = 'div{flex: 1 1 auto;}';
+        var output = 'div{flex: 1 1 0%;}';
         test(input, output, {}, done);
     });
     it('set flex-basis === 0% for flex-basis with plain 0', function(done) {
         var input = 'div{flex: 1 0 0;}';
         var output = 'div{flex: 1 0 0%;}';
         test(input, output, {}, done);
     });
-    it('set flex-basis === 0% for flex-basis with 0 px', function(done) {
-        var input = 'div{flex: 1 0 0 px;}';
+    it('set flex-basis === 0% for flex-basis with 0px', function(done) {
+        var input = 'div{flex: 1 0 0px;}';
         var output = 'div{flex: 1 0 0%;}';
         test(input, output, {}, done);
     });

specs/bug6Spec.js

@@ -3,7 +3,7 @@ var test = require('./test');
 describe('bug 6', function() {
     it('Set flex-shrink to 1 by default', function(done) {
         var input = 'div{flex: 1;}';
-        var output = 'div{flex: 1 1 auto;}';
+        var output = 'div{flex: 1 1 0%;}';
         test(input, output, {}, done);
     });
     describe('does nothing', function() {

specs/bug81aSpec.js

@@ -36,12 +36,12 @@ describe('bug 8.1.a', function() {
     describe('does nothing', function() {
         it('when using only first value', function(done) {
             var input = 'a{flex: 0}';
-            var output = 'a{flex: 0 1 auto}';
+            var output = 'a{flex: 0 1 0%}';
             test(input, output, {}, done);
         });
         it('when using only first and second values', function(done) {
             var input = 'a{flex: 0 0}';
-            var output = 'a{flex: 0 0 auto}';
+            var output = 'a{flex: 0 0 0%}';
             test(input, output, {}, done);
         });
         it('when not using calc', function(done) {