Merge pull request dgraham#5 from wyvernnot/master

Add no-size rule (fix dgraham#4)

Author: dgraham

README.md

@@ -59,6 +59,7 @@ Add `jquery` to the plugins section of your `.eslintrc` configuration file. You
     "jquery/no-proxy": 2,
     "jquery/no-serialize": 2,
     "jquery/no-show": 2,
+    "jquery/no-size": 2,
     "jquery/no-sizzle": 2,
     "jquery/no-slide": 2,
     "jquery/no-text": 2,

index.js

@@ -31,6 +31,7 @@ module.exports = {
     'no-parse-html': require('./rules/no-parse-html'),
     'no-prop': require('./rules/no-prop'),
     'no-proxy': require('./rules/no-proxy'),
+    'no-size': require('./rules/no-size'),
     'no-sizzle': require('./rules/no-sizzle'),
     'no-serialize': require('./rules/no-serialize'),
     'no-show': require('./rules/no-show'),
@@ -76,6 +77,7 @@ module.exports = {
         "jquery/no-proxy": 2,
         "jquery/no-serialize": 2,
         "jquery/no-show": 2,
+        "jquery/no-size": 2,
         "jquery/no-sizzle": 2,
         "jquery/no-slide": 2,
         "jquery/no-text": 2,

rules/no-size.js

@@ -0,0 +1,21 @@
+'use strict';
+
+const utils = require('./utils.js')
+
+module.exports = function(context) {
+  return {
+    CallExpression: function(node) {
+      if (node.callee.type !== 'MemberExpression') return
+      if (node.callee.property.name !== 'size') return
+
+      if (utils.isjQuery(node)) {
+        context.report({
+          node: node,
+          message: 'Prefer length to $.size'
+        })
+      }
+    }
+  }
+}
+
+module.exports.schema = []

tests/no-size.js

@@ -0,0 +1,34 @@
+'use strict';
+
+const rule = require('../rules/no-size')
+const RuleTester = require('eslint').RuleTester
+
+const error = 'Prefer length to $.size'
+
+const ruleTester = new RuleTester()
+ruleTester.run('no-size', rule, {
+  valid: [
+    'size()',
+    '[].size()',
+    'div.size()',
+    'div.size'
+  ],
+  invalid: [
+    {
+      code: '$("div").size()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$div.size()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$("div").first().size()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$("div").append($("input").size())',
+      errors: [{message: error, type: 'CallExpression'}]
+    }
+  ]
+})