From 5eda8e751c465208393a1a730ac3ebe1b2e27b08 Mon Sep 17 00:00:00 2001 From: mikcol Date: Wed, 7 Nov 2018 22:01:23 -0500 Subject: [PATCH 1/3] added ResizeCallback to ResizeSensor.d.ts and added static functions to ResizeSensor class --- src/ResizeSensor.d.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/ResizeSensor.d.ts b/src/ResizeSensor.d.ts index 82215ca..aa903b1 100644 --- a/src/ResizeSensor.d.ts +++ b/src/ResizeSensor.d.ts @@ -1,7 +1,12 @@ +export declare type ResizeCallback = (size: { width: number; height: number; }) => void; + declare class ResizeSensor { - constructor(element: (Element | Element[]), callback: Function); - detach(callback: Function): void; - reset(element: Element | Element[]): void; + constructor(element: Element | Element[], callback: ResizeCallback); + detach(callback: ResizeCallback): void; + reset(): void; + + static detach(element: Element | Element[], callback: ResizeCallback): void; + static reset(element: Element | Element[]): void; } export default ResizeSensor; From 1631dea1f96614d2defc895d5020a4210981c9f0 Mon Sep 17 00:00:00 2001 From: mikcol Date: Thu, 8 Nov 2018 10:06:42 -0500 Subject: [PATCH 2/3] renaming ResizeCallback to ResizeSensorCallback --- src/ResizeSensor.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ResizeSensor.d.ts b/src/ResizeSensor.d.ts index aa903b1..8fb1bbf 100644 --- a/src/ResizeSensor.d.ts +++ b/src/ResizeSensor.d.ts @@ -1,11 +1,11 @@ -export declare type ResizeCallback = (size: { width: number; height: number; }) => void; +export declare type ResizeSensorCallback = (size: { width: number; height: number; }) => void; declare class ResizeSensor { - constructor(element: Element | Element[], callback: ResizeCallback); - detach(callback: ResizeCallback): void; + constructor(element: Element | Element[], callback: ResizeSensorCallback); + detach(callback: ResizeSensorCallback): void; reset(): void; - static detach(element: Element | Element[], callback: ResizeCallback): void; + static detach(element: Element | Element[], callback: ResizeSensorCallback): void; static reset(element: Element | Element[]): void; } From baeb256a5e32a752d4cc57e0c97a3e64e6807d80 Mon Sep 17 00:00:00 2001 From: mikcol Date: Thu, 8 Nov 2018 10:18:37 -0500 Subject: [PATCH 3/3] added optional type to callback for detach methods on ResizeSensor --- src/ResizeSensor.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ResizeSensor.d.ts b/src/ResizeSensor.d.ts index 8fb1bbf..b0a5fdf 100644 --- a/src/ResizeSensor.d.ts +++ b/src/ResizeSensor.d.ts @@ -2,10 +2,10 @@ export declare type ResizeSensorCallback = (size: { width: number; height: numbe declare class ResizeSensor { constructor(element: Element | Element[], callback: ResizeSensorCallback); - detach(callback: ResizeSensorCallback): void; + detach(callback?: ResizeSensorCallback): void; reset(): void; - static detach(element: Element | Element[], callback: ResizeSensorCallback): void; + static detach(element: Element | Element[], callback?: ResizeSensorCallback): void; static reset(element: Element | Element[]): void; }