Made Codacy happy.

Author: ilgazer

app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java

@@ -1,6 +1,7 @@
 package fr.free.nrw.commons.explore.images;
 
 
+import android.annotation.SuppressLint;
 import android.content.SharedPreferences;
 import android.content.res.Configuration;
 import android.os.Bundle;
@@ -123,6 +124,7 @@ public void onScrollStateChanged(RecyclerView recyclerView, int newState) {
      * Checks for internet connection and then initializes the recycler view with 25 images of the searched query
      * Clearing imageAdapter every time new keyword is searched so that user can see only new results
      */
+    @SuppressLint("CheckResult")
     public void updateImageList(String query) {
         this.query = query;
         if(imagesNotFoundView != null) {
@@ -146,6 +148,7 @@ public void updateImageList(String query) {
     /**
      * Adds more results to existing search results
      */
+    @SuppressLint("CheckResult")
     public void addImagesToList(String query) {
         this.query = query;
         progressBar.setVisibility(View.VISIBLE);
@@ -163,13 +166,11 @@ public void addImagesToList(String query) {
      */
     private void handlePaginationSuccess(List<Media> mediaList) {
         progressBar.setVisibility(View.GONE);
-        if (mediaList.size()!=0){
-            if (!queryList.get(queryList.size()-1).getFilename().equals(mediaList.get(mediaList.size()-1).getFilename())) {
-                queryList.addAll(mediaList);
-                imagesAdapter.addAll(mediaList);
-                imagesAdapter.notifyDataSetChanged();
-                ((SearchActivity)getContext()).viewPagerNotifyDataSetChanged();
-            }
+        if (mediaList.size() != 0 || !queryList.get(queryList.size() - 1).getFilename().equals(mediaList.get(mediaList.size() - 1).getFilename())) {
+            queryList.addAll(mediaList);
+            imagesAdapter.addAll(mediaList);
+            imagesAdapter.notifyDataSetChanged();
+            ((SearchActivity) getContext()).viewPagerNotifyDataSetChanged();
         }
     }
 

app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

@@ -71,7 +71,7 @@ public boolean isDummy() {
         this.context = context;
         this.mwApi = mwApi;
         this.contentResolver = context.getContentResolver();
-        useExtStorage = prefs.getBoolean("useExternalStorage", true);
+        useExtStorage = this.prefs.getBoolean("useExternalStorage", true);
     }
 
     @SuppressLint("CheckResult")