Skip to content

Using as modular components #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChildishGiant opened this issue Oct 22, 2020 · 9 comments
Closed

Using as modular components #44

ChildishGiant opened this issue Oct 22, 2020 · 9 comments
Labels
bug Something isn't working
Milestone

Comments

@ChildishGiant
Copy link
Member

There's been a long-standing issue when trying to import parts of materialize individually (Dogfalo#5958) and from what others are saying it should be a fairly easy fix. Any thoughts?

@Smankusors
Copy link
Member

pardon me, but how is it "fairly easy fix"? 🤔

is that.... every js file needs to have it's own import even though it's already imported by the parent?

@ChildishGiant
Copy link
Member Author

The only issue is with component.js and people in the linked thread have made forks that fix this (from the looks of things)

@DanielRuf
Copy link

That would be very good if users can import the pieces they only need.

@DanielRuf DanielRuf added the enhancement New feature or request label Oct 25, 2020
@ChildishGiant
Copy link
Member Author

It's pretty much already there, there's just an issue with the component file. There's workarounds in the linked thread but those shouldn't be needed

@DanielRuf
Copy link

It's pretty much already there, there's just an issue with the component file.

That's what I meant, would be good to have this resolved so they can use this feature without any issues. So I guess it is a bugfix then or did it prevent the usage of the imports at all and it's a new feature?

@DanielRuf DanielRuf added bugfix and removed enhancement New feature or request labels Oct 26, 2020
@ChildishGiant
Copy link
Member Author

I've been using them as modules for a while but it was never intentionally supported to my knowledge, just a side effect of the structure.

@Smankusors Smankusors added bug Something isn't working and removed bugfix labels Apr 6, 2022
@LoganTann LoganTann added this to the 2.0.0 milestone Oct 14, 2022
@LoganTann
Copy link

Added to 2.0 milestone as it is not worth the time for a v1 update

@wuda-io wuda-io mentioned this issue Jul 19, 2023
4 tasks
@wuda-io
Copy link
Member

wuda-io commented Sep 1, 2023

I think this can be marked as solved due to the usage of typescript. Wdyt @danice ?

@danice
Copy link

danice commented Sep 3, 2023

I agree. The original request was about the difficulty of finding component dependencies and this is explicit now.

@wuda-io wuda-io closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants