FIX: enforces-shorthand false positive francoismassart#91

Author: francoismassart

README.md

@@ -33,6 +33,8 @@ If you enjoy my work you can:
 
 ## Latest changelog
 
+- FIX: [FIX: `enforces-shorthand` false positive](https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/91)
+
 - FIX: [`snap-x` and `snap-mandatory` are conflicting classes](https://github.com/francoismassart/eslint-plugin-tailwindcss/issues/90)
 
 - New rule: [`enforces-shorthand`](docs/rules/enforces-shorthand.md) merging multiple classnames when possible

lib/rules/enforces-shorthand.js

@@ -305,22 +305,27 @@ module.exports = {
       }
       let validatedClassNamesValue = union.join(isSingleLine ? ' ' : '\n');
       const originalPatched = isSingleLine ? originalClassNamesValue.trim() : originalClassNamesValue;
-      troubles.forEach((issue) => {
-        if (originalPatched !== validatedClassNamesValue) {
-          validatedClassNamesValue = prefix + validatedClassNamesValue + suffix;
-          context.report({
-            node: node,
-            messageId: 'shorthandCandidateDetected',
-            data: {
-              classnames: issue[0].join(', '),
-              shorthand: issue[1],
-            },
-            fix: function (fixer) {
-              return fixer.replaceTextRange([start, end], validatedClassNamesValue);
-            },
-          });
-        }
-      });
+      troubles
+        .filter((trouble) => {
+          // Only valid issue if there are classes to replace
+          return trouble[0].length;
+        })
+        .forEach((issue) => {
+          if (originalPatched !== validatedClassNamesValue) {
+            validatedClassNamesValue = prefix + validatedClassNamesValue + suffix;
+            context.report({
+              node: node,
+              messageId: 'shorthandCandidateDetected',
+              data: {
+                classnames: issue[0].join(', '),
+                shorthand: issue[1],
+              },
+              fix: function (fixer) {
+                return fixer.replaceTextRange([start, end], validatedClassNamesValue);
+              },
+            });
+          }
+        });
     };
 
     //----------------------------------------------------------------------