Skip to content

Commit 2e43de2

Browse files
committed
Cleanup 2nd param to ReactEventEmitter.ensureListening
It was removed, so these callsites aren't actually doing anything.
1 parent a41aa76 commit 2e43de2

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

src/core/ReactEventEmitter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ var ReactEventEmitter = {
244244

245245
/**
246246
* React references `ReactEventTopLevelCallback` using this property in order
247-
* to allow dependency injection via `ensureListening`.
247+
* to allow dependency injection.
248248
*/
249249
TopLevelCallbackCreator: null,
250250

src/core/__tests__/ReactEventEmitter-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ var ReactMount = require('ReactMount');
3939
var getID = ReactMount.getID;
4040
var setID = ReactMount.setID;
4141
var ReactEventEmitter;
42-
var ReactEventTopLevelCallback;
4342
var ReactTestUtils;
4443
var TapEventPlugin;
4544

@@ -94,10 +93,9 @@ describe('ReactEventEmitter', function() {
9493
setID = ReactMount.setID;
9594
ReactEventEmitter = require('ReactEventEmitter');
9695
ReactTestUtils = require('ReactTestUtils');
97-
ReactEventTopLevelCallback = require('ReactEventTopLevelCallback');
9896
idCallOrder = [];
9997
tapMoveThreshold = TapEventPlugin.tapMoveThreshold;
100-
ReactEventEmitter.ensureListening(false, ReactEventTopLevelCallback);
98+
ReactEventEmitter.ensureListening(false);
10199
EventPluginHub.injection.injectEventPluginsByName({
102100
TapEventPlugin: TapEventPlugin
103101
});

src/eventPlugins/__tests__/AnalyticsEventPlugin-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ describe('AnalyticsEventPlugin', function() {
2727
var EventPluginRegistry;
2828
var React;
2929
var ReactEventEmitter;
30-
var ReactEventTopLevelCallback;
3130
var ReactTestUtils;
3231

3332
var DefaultEventPluginOrder;
@@ -42,7 +41,6 @@ describe('AnalyticsEventPlugin', function() {
4241
EventPluginRegistry = require('EventPluginRegistry');
4342
React = require('React');
4443
ReactEventEmitter = require('ReactEventEmitter');
45-
ReactEventTopLevelCallback = require('ReactEventTopLevelCallback');
4644
ReactTestUtils = require('ReactTestUtils');
4745

4846
EventPluginRegistry._resetEventPlugins();
@@ -63,7 +61,7 @@ describe('AnalyticsEventPlugin', function() {
6361
'ChangeEventPlugin': ChangeEventPlugin
6462
});
6563

66-
ReactEventEmitter.ensureListening(false, ReactEventTopLevelCallback);
64+
ReactEventEmitter.ensureListening(false);
6765
});
6866

6967
it('should count events correctly', function() {

0 commit comments

Comments
 (0)