[CSV-128] CSVFormat.EXCEL should ignore empty header names

garydgregory · garydgregory · commit c81ad0328eef · 2014-08-27T14:12:40.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1620902 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -38,7 +38,9 @@
     <title>Release Notes</title>
   </properties>
   <body>
-
+    <release version="1.1" date="2014-mm-dd" description="Feature and bug fix release">
+      <action issue="CSV-128" type="fix" dev="britter">CSVFormat.EXCEL should ignore empty header names</action>
+    </release>
     <release version="1.0" date="2014-08-14" description="First release">
       <action issue="CSV-125" type="fix" dev="britter">No longer works with Java 6</action>
       <action issue="CSV-122" type="fix" dev="britter" due-to="Mike Lewis">NullPointerException when empty header string and and null string of ""</action>
diff --git a/src/main/java/org/apache/commons/csv/CSVFormat.java b/src/main/java/org/apache/commons/csv/CSVFormat.java
@@ -206,16 +206,17 @@ public final class CSVFormat implements Serializable {
      * Settings are:
      * </p>
      * <ul>
-     *   <li>withDelimiter(',')</li>
-     *   <li>withQuoteChar('"')</li>
-     *   <li>withRecordSeparator("\r\n")</li>
-     *   <li>withIgnoreEmptyLines(false)</li>
+     *   <li>{@link #withDelimiter(char) withDelimiter(',')}</li>
+     *   <li>{@link #withQuoteChar(String) withQuoteChar('"')}</li>
+     *   <li>{@link #withRecordSeparator(String) withRecordSeparator("\r\n")}</li>
+     *   <li>{@link #withIgnoreEmptyLines(boolean) withIgnoreEmptyLines(false)}</li>
+     *   <li>{@link #withAllowMissingColumnNames(boolean) withAllowMissingColumnNames(true)}</li>
      * </ul>
      * <p>
-     * Note: this is currently the same as {@link #RFC4180}.
+     * Note: this is currently like {@link #RFC4180} plus {@link #withAllowMissingColumnNames(boolean) withAllowMissingColumnNames(true)}.
      * </p>
      */
-    public static final CSVFormat EXCEL = DEFAULT.withIgnoreEmptyLines(false);
+    public static final CSVFormat EXCEL = DEFAULT.withIgnoreEmptyLines(false).withAllowMissingColumnNames(true);
 
     /**
      * Tab-delimited format.
diff --git a/src/test/java/org/apache/commons/csv/CSVParserTest.java b/src/test/java/org/apache/commons/csv/CSVParserTest.java
