Make sure watcher.set() isn't being called when active

Conflicts:

	lib/dns.js

Author: ry

lib/dns.js

@@ -11,10 +11,9 @@ timer.callback = function () {
   var sockets = Object.keys(activeWatchers);
   for (var i = 0, l = sockets.length; i < l; i++) {
     var socket = sockets[i];
-    var s = parseInt(socket);
-    channel.processFD( watchers[socket].read  ? s : dns.SOCKET_BAD
-                     , watchers[socket].write ? s : dns.SOCKET_BAD
-                     );
+    var s = parseInt(socket, 10);
+    channel.processFD(watchers[socket].read  ? s : dns.SOCKET_BAD,
+                      watchers[socket].write ? s : dns.SOCKET_BAD);
   }
   updateTimer();
 }
@@ -50,20 +49,19 @@ var channel = new dns.Channel({SOCK_STATE_CB: function (socket, read, write) {
                        };
 
     watcher.callback = function(read, write)  {
-      channel.processFD( read  ? socket : dns.SOCKET_BAD
-                       , write ? socket : dns.SOCKET_BAD
-                       );
+      channel.processFD(read  ? socket : dns.SOCKET_BAD,
+                        write ? socket : dns.SOCKET_BAD);
       updateTimer();
     }
   }
 
-  watcher.set(socket, read == 1, write == 1);
+  watcher.stop();
 
   if (!(read || write)) {
-    watcher.stop();
     delete activeWatchers[socket];
     return;
   } else {
+    watcher.set(socket, read == 1, write == 1);
     watcher.start();
     activeWatchers[socket] = watcher;
   }

src/node_io_watcher.cc

@@ -135,6 +135,7 @@ Handle<Value> IOWatcher::Set(const Arguments& args) {
 
   if (args[2]->IsTrue()) events |= EV_WRITE;
 
+  assert(!io->watcher_.active);
   ev_io_set(&io->watcher_, fd, events);
 
   return Undefined();