Skip to content

Commit 484774a

Browse files
fix: various code issues (#161)
* http -> https * un used namespace * remove redundant `</link>` tags * fix label for attributes * provide generic fallback fonts * remove overridden properties in same rule * language issues * provide function instead of an object as argument * fix remaining closing tags * fix remaining closing tags * Update target-text/index.html * Update target-text/index.html --------- Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
1 parent b97efcc commit 484774a

File tree

36 files changed

+55
-67
lines changed

36 files changed

+55
-67
lines changed

backdrop/script.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function toggleFullscreen() {
3636
if (!document.fullscreenElement) {
3737
elem
3838
.requestFullscreen()
39-
.then({})
39+
.then(() => {})
4040
.catch((err) => {
4141
alert(
4242
`Error attempting to enable full-screen mode: ${err.message} (${err.name})`,

counter-style-demo/css/style.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ body {
2828
.header h1 {
2929
margin: 0;
3030
padding: 0;
31-
font-family: Ubuntu, Arial, Tahoma, "Sans Serif";
31+
font-family: Ubuntu, Arial, Tahoma, sans-serif;
3232
}
3333

3434
.header {
@@ -41,7 +41,7 @@ body {
4141
.notes-section {
4242
margin: 10px;
4343
color: #4d4e53;
44-
font-family: Ubuntu, Arial, Tahoma, "Sans Serif";
44+
font-family: Ubuntu, Arial, Tahoma, sans-serif;
4545
float: left;
4646
}
4747

css-cookbook/sharp-account_box-24px.svg

+1-1
Loading

editable-samples-2/pages/filter/svg/example.svg

+1-2
Loading

editable-samples/codemirror/mode/css/gss.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22

33
<title>CodeMirror: Closure Stylesheets (GSS) mode</title>
44
<meta charset="utf-8"/>
5-
<link rel=stylesheet href="../../doc/docs.css">
5+
<link rel=stylesheet href="../../doc/docs.css" />
66

7-
<link rel="stylesheet" href="../../lib/codemirror.css">
8-
<link rel="stylesheet" href="../../addon/hint/show-hint.css">
7+
<link rel="stylesheet" href="../../lib/codemirror.css" />
8+
<link rel="stylesheet" href="../../addon/hint/show-hint.css" />
99
<script src="../../lib/codemirror.js"></script>
1010
<script src="css.js"></script>
1111
<script src="../../addon/hint/show-hint.js"></script>
1212
<script src="../../addon/hint/css-hint.js"></script>
1313
<style>.CodeMirror {background: #f8f8f8;}</style>
1414
<div id=nav>
15-
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
15+
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
1616

1717
<ul>
1818
<li><a href="../../index.html">Home</a>

editable-samples/codemirror/mode/css/index.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22

33
<title>CodeMirror: CSS mode</title>
44
<meta charset="utf-8"/>
5-
<link rel=stylesheet href="../../doc/docs.css">
5+
<link rel=stylesheet href="../../doc/docs.css" />
66

7-
<link rel="stylesheet" href="../../lib/codemirror.css">
8-
<link rel="stylesheet" href="../../addon/hint/show-hint.css">
7+
<link rel="stylesheet" href="../../lib/codemirror.css" />
8+
<link rel="stylesheet" href="../../addon/hint/show-hint.css" />
99
<script src="../../lib/codemirror.js"></script>
1010
<script src="css.js"></script>
1111
<script src="../../addon/hint/show-hint.js"></script>
1212
<script src="../../addon/hint/css-hint.js"></script>
1313
<style>.CodeMirror {background: #f8f8f8;}</style>
1414
<div id=nav>
15-
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
15+
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
1616

1717
<ul>
1818
<li><a href="../../index.html">Home</a>

editable-samples/codemirror/mode/css/less.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
<title>CodeMirror: LESS mode</title>
44
<meta charset="utf-8"/>
5-
<link rel=stylesheet href="../../doc/docs.css">
5+
<link rel=stylesheet href="../../doc/docs.css" />
66

7-
<link rel="stylesheet" href="../../lib/codemirror.css">
7+
<link rel="stylesheet" href="../../lib/codemirror.css" />
88
<script src="../../lib/codemirror.js"></script>
99
<script src="../../addon/edit/matchbrackets.js"></script>
1010
<script src="css.js"></script>
1111
<style>.CodeMirror {border: 1px solid #ddd; line-height: 1.2;}</style>
1212
<div id=nav>
13-
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
13+
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
1414

1515
<ul>
1616
<li><a href="../../index.html">Home</a>

editable-samples/codemirror/mode/css/scss.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
<title>CodeMirror: SCSS mode</title>
44
<meta charset="utf-8"/>
5-
<link rel=stylesheet href="../../doc/docs.css">
5+
<link rel=stylesheet href="../../doc/docs.css" />
66

7-
<link rel="stylesheet" href="../../lib/codemirror.css">
7+
<link rel="stylesheet" href="../../lib/codemirror.css" />
88
<script src="../../lib/codemirror.js"></script>
99
<script src="css.js"></script>
1010
<style>.CodeMirror {background: #f8f8f8;}</style>
1111
<div id=nav>
12-
<a href="http://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
12+
<a href="https://codemirror.net"><h1>CodeMirror</h1><img id=logo src="../../doc/logo.png"></a>
1313

1414
<ul>
1515
<li><a href="../../index.html">Home</a>

editable-samples/pages/border-top-color/index-old.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
<head>
44
<meta charset="utf-8" />
55
<meta name="viewport" content="width=device-width" />
6-
<link href="../../css/editable-old.css" rel="stylesheet"></link>
6+
<link href="../../css/editable-old.css" rel="stylesheet" />
77

8-
<link href="../../codemirror/lib/codemirror.css" rel="stylesheet">
9-
<link href="../../codemirror/theme/mdn-like.css" rel="stylesheet"></link>
10-
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet"></link>
8+
<link href="../../codemirror/lib/codemirror.css" rel="stylesheet" />
9+
<link href="../../codemirror/theme/mdn-like.css" rel="stylesheet" />
10+
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet" />
1111

12-
<link href="css/element.css" rel="stylesheet"></link>
12+
<link href="css/element.css" rel="stylesheet" />
1313
</head>
1414

1515
<body>
@@ -31,7 +31,7 @@
3131
<script src="../../codemirror/mode/css/css.js"></script>
3232
<script src="../../codemirror/addon/hint/css-hint.js"></script>
3333
<script src="../../codemirror/addon/hint/show-hint.js"></script>
34-
34+
3535
<script src="js/border-top-color.js"></script>
3636
<script src="../../js/editable-old.js"></script>
3737
</body>

editable-samples/pages/border-top-color/index.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
<head>
44
<meta charset="utf-8" />
55
<meta name="viewport" content="width=device-width" />
6-
<link href="../../css/editable.css" rel="stylesheet"></link>
6+
<link href="../../css/editable.css" rel="stylesheet" />
77

8-
<link href="../../codemirror/lib/codemirror.css" rel="stylesheet">
9-
<link href="../../codemirror/theme/eclipse.css" rel="stylesheet"></link>
10-
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet"></link>
8+
<link href="../../codemirror/lib/codemirror.css" rel="stylesheet" />
9+
<link href="../../codemirror/theme/eclipse.css" rel="stylesheet" />
10+
<link href="../../codemirror/addon/hint/show-hint.css" rel="stylesheet" />
1111

12-
<link href="css/element.css" rel="stylesheet"></link>
12+
<link href="css/element.css" rel="stylesheet" />
1313
</head>
1414

1515
<body>
@@ -30,7 +30,7 @@
3030
<script src="../../codemirror/mode/css/css.js"></script>
3131
<script src="../../codemirror/addon/hint/css-hint.js"></script>
3232
<script src="../../codemirror/addon/hint/show-hint.js"></script>
33-
33+
3434
<script src="js/border-top-color.js"></script>
3535
<script src="../../js/editable.js"></script>
3636
</body>

flexbox/use-cases/MDN.svg

+1-2
Loading

font-features/font-variant-alternates.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
}
4848

4949
.script {
50-
font-family: "Dancing Script";
50+
font-family: "Dancing Script", serif;
5151
}
5252

5353
.wrapper {

font-features/font-variant-numeric-example.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
.ordinal {
1717
font-variant-numeric: ordinal;
18-
font-family: "Source Sans Pro";
18+
font-family: "Source Sans Pro", sans-serif;
1919
}
2020
</style>
2121
</head>

learn/getting-started--download.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h1>I am a level one heading</h1>
1212
<p>
1313
This is a paragraph of text. In the text is a
1414
<span>span element</span> and also a
15-
<a href="http://example.com">link</a>.
15+
<a href="https://example.com">link</a>.
1616
</p>
1717

1818
<p>

learn/getting-started/biog-download.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ <h2>Contact information</h2>
6464
</li>
6565
<li>
6666
Web:
67-
<a href="http://example.com">http://example.com</a>
67+
<a href="https://example.com">https://example.com</a>
6868
</li>
6969
<li>Tel: 123 45678</li>
7070
</ul>

learn/getting-started/biog.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ <h1>Jane Doe</h1>
5959
<h2>Contact information</h2>
6060
<ul>
6161
<li>Email: <a href="mailto:jane@example.com">jane@example.com</a></li>
62-
<li>Web: <a href="http://example.com">http://example.com</a></li>
62+
<li>Web: <a href="https://example.com">https://example.com</a></li>
6363
<li>Tel: 123 45678</li>
6464
</ul>
6565
</section>

learn/getting-started/started1.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ <h1>I am a level one heading</h1>
2222
<p>
2323
This is a paragraph of text. In the text is a
2424
<span>span element</span> and also a
25-
<a href="http://example.com">link</a>.
25+
<a href="https://example.com">link</a>.
2626
</p>
2727

2828
<p>

learn/getting-started/started2.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ <h1>I am a level one heading</h1>
2424
<p>
2525
This is a paragraph of text. In the text is a
2626
<span>span element</span> and also a
27-
<a href="http://example.com">link</a>.
27+
<a href="https://example.com">link</a>.
2828
</p>
2929

3030
<p>

learn/getting-started/started3.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h1>I am a level one heading</h1>
2828
<p>
2929
This is a paragraph of text. In the text is a
3030
<span>span element</span> and also a
31-
<a href="http://example.com">link</a>.
31+
<a href="https://example.com">link</a>.
3232
</p>
3333

3434
<p>

learn/selectors/attribute-links.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<ul>
3535
<li><a href="https://example.com">Link 1</a></li>
3636
<li>
37-
<a href="http://example.com" title="Visit example.com">Link 2</a>
37+
<a href="https://example.com" title="Visit example.com">Link 2</a>
3838
</li>
3939
<li><a href="/contact">Link 3</a></li>
4040
<li><a href="../contact/index.html">Link 4</a></li>

learn/tasks/float/marking.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ In task 2 we check that the student understands how to clear an element from a f
3333

3434
## Task 3
3535

36-
In the final task the student is asked to use the most up to date method of clearing the box underneath the floated item. Therefore they should add `display: flow-root` to the class for `.box`. Other methods might be to use `overflow` or a clearfix hack, however the learning materials detail the `flow-root` method as the modern way to achieve this.
36+
In the final task the student is asked to use the most up-to-date method of clearing the box underneath the floated item. Therefore they should add `display: flow-root` to the class for `.box`. Other methods might be to use `overflow` or a clearfix hack, however the learning materials detail the `flow-root` method as the modern way to achieve this.
3737

3838
```
3939
.box {

learn/tasks/selectors/attribute-links-download.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<a href="https://example.com">Link 1</a>
4646
</li>
4747
<li>
48-
<a href="http://example.com" title="Visit example.com">Link 2</a>
48+
<a href="https://example.com" title="Visit example.com">Link 2</a>
4949
</li>
5050
<li>
5151
<a href="/contact">Link 3</a>

learn/tasks/selectors/attribute-links.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<ul>
3535
<li><a href="https://example.com">Link 1</a></li>
3636
<li>
37-
<a href="http://example.com" title="Visit example.com">Link 2</a>
37+
<a href="https://example.com" title="Visit example.com">Link 2</a>
3838
</li>
3939
<li><a href="/contact">Link 3</a></li>
4040
<li><a href="../contact/index.html">Link 4</a></li>

learn/tasks/selectors/pseudo.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<section class="preview">
2929
<div class="container">
3030
<p>
31-
Veggies es <a href="http://example.com">bonus vobis</a>, proinde vos
31+
Veggies es <a href="https://example.com">bonus vobis</a>, proinde vos
3232
postulo essum magis kohlrabi welsh onion daikon amaranth tatsoi
3333
tomatillo melon azuki bean garlic.
3434
</p>

logical/size-max.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<div class="container">
3939
<div class="physical box">I have a max-width of 200px.</div>
4040

41-
<div class="logical box">I have an max-inline-size of 200px.</div>
41+
<div class="logical box">I have a max-inline-size of 200px.</div>
4242
</div>
4343
</section>
4444

masking/MDN.svg

+1-2
Loading

masking/star.svg

+1-2
Loading

scroll-snap/mandatory-y-old-spec.html

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
scroll-snap-points-y: repeat(320px);
2929
scroll-snap-destination: 0 0;
3030
scroll-snap-type: y mandatory;
31-
scroll-snap-type: mandatory;
3231
}
3332

3433
.scroller section {

tools/border-image-generator/styles.css

+1-4
Original file line numberDiff line numberDiff line change
@@ -194,9 +194,7 @@
194194
margin: 0;
195195
padding: 0 0.3em;
196196

197-
border: 3px solid #3490d2;
198-
border-color: #208b20;
199-
background: #666;
197+
border: 3px solid #208b20;
200198
background-color: #eef1f5;
201199
color: #000;
202200

@@ -889,7 +887,6 @@ body[data-move="Y"] {
889887
text-align: center;
890888
color: #555;
891889

892-
position: absolute;
893890
z-index: 1000;
894891

895892
box-shadow: 0 0 3px 0 #bababa;

tools/border-radius-generator/styles.css

-1
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,6 @@ body {
520520
margin: 0;
521521
padding: 0 0 0 10px;
522522
background: #555;
523-
border: 1px solid #555;
524523
border: none;
525524
color: #fff;
526525
float: left;

0 commit comments

Comments
 (0)