Apply suggestions from code review

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>

Author: estelle

modules/colors.html

@@ -113,7 +113,7 @@
 
       function createColor() {
         const currentColor = colorPicker.value;
-        const currentOpacity = opacityPicker.value * 1;
+        const currentOpacity = Number(opacityPicker.value);
         setBackgroundColor(currentColor, currentOpacity);
         createHEX(currentColor, currentOpacity);
         createRGB(currentColor, currentOpacity);
@@ -146,27 +146,37 @@
 
       function createHSL(r, g, b, opacity) {
         const cell = document.querySelector("#HSL td");
-        (r = r / 255), (g = g / 255), (b = b / 255);
+        // Let's have r, g, b in the range [0, 1]
+        r = r / 255;
+        g = g / 255;
+        b = b / 255;
         const cmin = Math.min(r, g, b);
         const cmax = Math.max(r, g, b);
         const delta = cmax - cmin;
         let h = 0,
           s = 0,
           l = 0;
 
-        if (delta === 0) h = 0;
-        else if (cmax === r) h = ((g - b) / delta) % 6;
-        else if (cmax === g) h = (b - r) / delta + 2;
+        if (delta === 0) {
+          h = 0;
+        } else if (cmax === r) {
+          h = ((g - b) / delta) % 6;
+        } else if (cmax === g) {
+          h = (b - r) / delta + 2;
+        }
         else h = (r - g) / delta + 4;
 
         h = Math.round(h * 60);
 
-        if (h < 0) h += 360;
+        // We want an angle between 0 and 360°
+        if (h < 0) {
+          h += 360;
+        }
 
         l = (cmax + cmin) / 2;
         s = (delta === 0) ? 0 : delta / (1 - Math.abs(2 * l - 1));
-        s = +(s * 100).toFixed(1);
-        l = +(l * 100).toFixed(1);
+        s = Number((s * 100).toFixed(1));
+        l = Number((l * 100).toFixed(1));
 
         if (opacity === 1) {
           cell.textContent = `hsl(${h} ${s}% ${l}%)`;