Skip to content

Commit 1e909a2

Browse files
shanssvgeesus
authored andcommitted
mark TimedITem.player and Animatable.getCurrentAnimations at risk
1 parent bcc303b commit 1e909a2

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

web-animations/index.html

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6587,6 +6587,13 @@ <h3>The <code>TimedItem</code> interface</h3>
65876587
This will be <code>null</code> if this <a>timed
65886588
item</a> is not <a>associated with a player</a>.
65896589
</p>
6590+
<p class='issue'>
6591+
Feedback has been provided that suggests this reference causes the
6592+
relationship between AnimationPlayers and TimedItems to be circular,
6593+
which confuses the model. The player attribute should be considered
6594+
<strong>at risk</strong> unless a strong use case for the reference
6595+
arises.
6596+
</p>
65906597
</dd>
65916598
<dt>// Event callbacks</dt><dd></dd>
65926599
<dt>attribute EventHandler onstart</dt>
@@ -7577,6 +7584,15 @@ <h3>The <code>Animatable</code> interface</h3>
75777584
<code>Element</code> are treated as independent <a>Animatable</a>
75787585
objects.
75797586
</p>
7587+
<p class="issue">
7588+
Feedback has been provided that suggests direct references from
7589+
TimedItem objects to AnimationPlayers generate circular reference and
7590+
confuse the model. Without this reference, getCurrentAnimations is
7591+
not very useful, as the returned TimedItems can't be used to effect
7592+
play control. In the absence of a strong use case for a reference from
7593+
TimedItem to AnimationPlayer, this feature should be considered
7594+
<strong>at risk</strong>.
7595+
</p>
75807596
</dd>
75817597
<dt>sequence&lt;AnimationPlayer&gt; getAnimationPlayers()</dt>
75827598
<dd>

0 commit comments

Comments
 (0)