Skip to content

Commit 55b5a20

Browse files
annevkannevk
committed
make it more clear that the MediaList section has open issues; point those out in SGML comments
1 parent 131c965 commit 55b5a20

2 files changed

Lines changed: 47 additions & 53 deletions

File tree

‎cssom/Overview.html‎

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,16 +1157,11 @@ <h3 id=the-stylesheet><span class=secno>2.8. </span>The <code><a
11571157
<code>boolean</code>
11581158

11591159
<dd>
1160-
<p>This attribute affects which style sheets are <span title="enabled
1161-
style sheet">enabled</span>.</p>
1162-
11631160
<p>On getting, this attribute <em class=ct>must</em> be <code>true</code>
11641161
when the style sheet is disabled and <code>false</code> otherwise.</p>
11651162

11661163
<p>On setting, a value of <code>true</code> <em class=ct>must</em>
1167-
disable the style sheet and a value of <code>false</code> enables it.</p>
1168-
</dd>
1169-
<!-- XXX: the first person to detect the loop gets a cookie -->
1164+
disable the style sheet and a value of <code>false</code> enable it.</p>
11701165

11711166
<dt><dfn id=stylesheet-ownernode
11721167
title=stylesheet-ownernode><code>ownerNode</code></dfn> of type
@@ -1217,6 +1212,7 @@ <h3 id=the-stylesheet><span class=secno>2.8. </span>The <code><a
12171212
class=ct>must</em> set the value of <code title=medialist-mediatext><a
12181213
href="#medialist-mediatext">mediaText</a></code> on the <code><a
12191214
href="#medialist">MediaList</a></code> object.</p>
1215+
<!-- XXX -->
12201216
</dl>
12211217

12221218
<h3 id=the-medialist><span class=secno>2.9. </span>The <code><a
@@ -1260,11 +1256,10 @@ <h3 id=the-medialist><span class=secno>2.9. </span>The <code><a
12601256
list of <a href="#canon-media" title=canon-media>normalized media
12611257
queries</a> or the empty string otherwise.</p>
12621258

1263-
<p>On setting a <code>SYNTAX_ERR</code> exception <em class=ct>must</em>
1264-
be thrown if the given media query or comma-separated list of media
1265-
queries is invalid. Otherwise the value is set to the given value.</p>
1266-
1267-
<p class=issue>Should setting to "foobar" work? Need to test!!11!</p>
1259+
<p>On setting <span class=issue>...</span>.</p>
1260+
<!-- XXX Media Queries need to define parsing of media queries more
1261+
accurately. -->
1262+
12681263

12691264
<dt><dfn id=medialist-length
12701265
title=medialist-length><code>length</code></dfn> of type <code>unsigned
@@ -1287,19 +1282,22 @@ <h3 id=the-medialist><span class=secno>2.9. </span>The <code><a
12871282
title=medialist-appendmedium><code>appendMedium(<var
12881283
title="">medium</var>)</code></dfn>, method
12891284

1290-
<dd>When invoked with an invalid <var>medium</var> <em class=ct>must</em>
1291-
throw a <code>INVALID_CHARACTER_ERR</code> exception, otherwise it <em
1292-
class=ct>must</em> act as if <code>deleteMedium</code> was invoked with
1293-
<var>newMedium</var> as argument (if it was in the list) and add
1294-
<var>newMedium</var> to the end of the list.
1285+
<dd>When invoked, <span class=issue>...</span>. <!--
1286+
XXX see above, Media Queries need to define parsing of media queries.
1287+
1288+
otherwise it <em class="ct">must</em> act as if
1289+
<code>deleteMedium</code> was invoked with <var>newMedium</var> as argument
1290+
(if it was in the list) and add <var>newMedium</var> to the end of the
1291+
list.
1292+
-->
12951293

12961294
<dt><dfn id=medialist-deletemedium
12971295
title=medialist-deletemedium><code>deleteMedium(<var
12981296
title="">medium</var>)</code></dfn>, method
12991297

13001298
<dd>This method, when invoked, <em class=ct>must</em> raise a
1301-
<code>NOT_FOUND_ERR</code> exception when <var>medium</var> was not in
1302-
the collection. Otherwise, <var>medium</var> <em class=ct>must</em> be
1299+
<code>NOT_FOUND_ERR</code> exception when <var>medium</var> is not in the
1300+
collection. Otherwise, <var>medium</var> <em class=ct>must</em> be
13031301
removed from the collection.
13041302
</dl>
13051303

‎cssom/Overview.src.html‎

Lines changed: 31 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -804,18 +804,13 @@ <h3>The <code>StyleSheet</code> Interface</h3>
804804
of type <code>boolean</code></dt>
805805

806806
<dd>
807-
<p>This attribute affects which style sheets are
808-
<span title="enabled style sheet">enabled</span>.</p>
809-
810807
<p>On getting, this attribute <em class="ct">must</em> be <code>true</code>
811808
when the style sheet is disabled and <code>false</code> otherwise.</p>
812809

813810
<p>On setting, a value of <code>true</code> <em class="ct">must</em> disable
814-
the style sheet and a value of <code>false</code> enables it.</p>
811+
the style sheet and a value of <code>false</code> enable it.</p>
815812
</dd>
816813

817-
<!-- XXX: the first person to detect the loop gets a cookie -->
818-
819814
<dt><dfn id="stylesheet-ownernode" title="stylesheet-ownernode"><code>ownerNode</code></dfn>
820815
of type <code>Node</code>, readonly</dt>
821816

@@ -825,41 +820,41 @@ <h3>The <code>StyleSheet</code> Interface</h3>
825820
interface.</dd>
826821

827822
<dt><dfn id="stylesheet-parentstylesheet" title="stylesheet-parentstylesheet"><code>parentStyleSheet</code></dfn>
828-
of type <code>StyleSheet</code>, readonly</dt>
823+
of type <code>StyleSheet</code>, readonly</dt>
829824

830825
<dd>This attribute <em class="ct">must</em> be the <code>StyleSheet</code>
831-
object that caused the inclusion of the current style sheet or
832-
<code>null</code> if there is no such object.</dd>
826+
object that caused the inclusion of the current style sheet or
827+
<code>null</code> if there is no such object.</dd>
833828

834-
<dt><dfn id="stylesheet-href" title="stylesheet-href"><code>href</code></dfn> of type
835-
<code>DOMString</code>, readonly</dt>
829+
<dt><dfn id="stylesheet-href" title="stylesheet-href"><code>href</code></dfn>
830+
of type <code>DOMString</code>, readonly</dt>
836831

837832
<dd>This attribute <em class="ct">must</em> be an IRI pointing to the
838-
location of the standalone style sheet or <code>null</code> otherwise
839-
(when it's inside a <code>style</code> element for example).</dd>
840-
833+
location of the standalone style sheet or <code>null</code> otherwise (when
834+
it's inside a <code>style</code> element for example).</dd>
841835
<!-- XXX: ready for IRI-hell? -->
842836

843837
<dt><dfn id="stylesheet-title" title="stylesheet-title"><code>title</code></dfn>
844-
of type <code>DOMString</code></dt>
838+
of type <code>DOMString</code></dt>
845839

846840
<dd>This attribute <em class="ct">must</em> be the
847-
<span title="have a title">title</span> of the style sheet. In HTML this can
848-
obtained from the <code>HTMLLinkElement</code> or
849-
<code>HTMLStyleElement</code> for example.</dd>
841+
<span title="have a title">title</span> of the style sheet. In HTML this can
842+
obtained from the <code>HTMLLinkElement</code> or
843+
<code>HTMLStyleElement</code> for example.</dd>
850844

851-
<dt><dfn id="stylesheet-media" title="stylesheet-media"><code>media</code></dfn> of type
852-
<code>MediaList</code>, readonly</dt>
845+
<dt><dfn id="stylesheet-media" title="stylesheet-media"><code>media</code></dfn>
846+
of type <code>MediaList</code>, readonly</dt>
853847

854848
<dd>
855849
<p>This attribute <em class="ct">must</em> be a <code>MediaList</code>
856-
object.</p>
850+
object.</p>
857851

858852
<p>In binding languages that support setting to a readonly attribute setting
859-
<code title="stylesheet-media">media</code> to a string
860-
<em class="ct">must</em> set the value of
861-
<code title="medialist-mediatext">mediaText</code> on the
862-
<code>MediaList</code> object.</p>
853+
<code title="stylesheet-media">media</code> to a string
854+
<em class="ct">must</em> set the value of
855+
<code title="medialist-mediatext">mediaText</code> on the
856+
<code>MediaList</code> object.</p>
857+
<!-- XXX -->
863858
</dd>
864859

865860
</dl>
@@ -903,11 +898,9 @@ <h3>The <code>MediaList</code> Interface</h3>
903898
list of <span title="canon-media">normalized media queries</span> or the
904899
empty string otherwise.</p>
905900

906-
<p>On setting a <code>SYNTAX_ERR</code> exception <em class="ct">must</em>
907-
be thrown if the given media query or comma-separated list of media queries
908-
is invalid. Otherwise the value is set to the given value.</p>
909-
910-
<p class="issue">Should setting to "foobar" work? Need to test!!11!</p>
901+
<p>On setting <span class="issue">...</span>.</p>
902+
<!-- XXX Media Queries need to define parsing of media queries more
903+
accurately. -->
911904
</dd>
912905

913906
<dt><dfn id="medialist-length" title="medialist-length"><code>length</code></dfn>
@@ -929,18 +922,21 @@ <h3>The <code>MediaList</code> Interface</h3>
929922
<dt><dfn id="medialist-appendmedium" title="medialist-appendmedium"><code>appendMedium(<var title="">medium</var>)</code></dfn>,
930923
method</dt>
931924

932-
<dd>When invoked with an invalid <var>medium</var>
933-
<em class="ct">must</em> throw a <code>INVALID_CHARACTER_ERR</code>
934-
exception, otherwise it <em class="ct">must</em> act as if
925+
<dd>When invoked, <span class="issue">...</span>.
926+
<!--
927+
XXX see above, Media Queries need to define parsing of media queries.
928+
929+
otherwise it <em class="ct">must</em> act as if
935930
<code>deleteMedium</code> was invoked with <var>newMedium</var> as argument
936931
(if it was in the list) and add <var>newMedium</var> to the end of the
937-
list.</dd>
932+
list.
933+
--></dd>
938934

939935
<dt><dfn id="medialist-deletemedium" title="medialist-deletemedium"><code>deleteMedium(<var title="">medium</var>)</code></dfn>,
940936
method</dt>
941937

942938
<dd>This method, when invoked, <em class="ct">must</em> raise a
943-
<code>NOT_FOUND_ERR</code> exception when <var>medium</var> was not in the
939+
<code>NOT_FOUND_ERR</code> exception when <var>medium</var> is not in the
944940
collection. Otherwise, <var>medium</var> <em class="ct">must</em> be removed
945941
from the collection.</dd>
946942

0 commit comments

Comments
 (0)