Skip to content

Commit ef1c7e4

Browse files
committed
Fix handling of verified lines that aren't URLs.
1 parent 7b373b8 commit ef1c7e4

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

bin/issuegen.pl

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
From: [name]
3333
Comment: [url]
3434
Response: [url]
35-
Closed: [Accepted/OutOfScope/Invalid/Rejected/Retracted/Deferred ... or replace this "Closed" line with "Open"]
35+
Closed: Accepted/OutOfScope/Invalid/Rejected/Retracted/Deferred ... or replace this line with "Open"
3636
Verified: [url]
37-
Resolved: Editorial/Bugfix (for obvious fixes)/Editors' discretion/[url to minutes]
37+
Resolved: Editorial/Bugfix (for obvious fixes)/Editor discretion/[url to minutes]
3838
----
3939
XXX
4040
exit;
@@ -83,6 +83,7 @@
8383
to understand this issue and its resolution.
8484
8585
Closed: A status line on how the issue was closed. Triggers colors.
86+
Replacing "Closed" with "Open" marks the issue unresolved.
8687
8788
Verified: URL to a message where the commenter indicates satisfaction
8889
with the resolution of the issue.
@@ -98,7 +99,7 @@
9899
Editorial - no substantive change
99100
Bugfix - fixes an obvious error with an obvious solution
100101
[URL] - link to WG resolution closing the issue
101-
Editor's discretion -
102+
Editor discretion -
102103
This is the tricky one. It's used in cases where
103104
1. the solution isn't obvious (not Bugfix)
104105
2. the impact of the solution is minor and localized:
@@ -145,13 +146,13 @@
145146

146147
# Color coding
147148
$code = '';
148-
if (/\nVerified:\s+http/) {
149+
if (/\nVerified:\s+\S+/) {
149150
$code = 'a';
150151
}
151152
elsif (/\n(?:Closed|Open):\s+(\S+)/) {
152153
$code = $statusStyle{lc $1};
153154
}
154-
if (/\nOpen/ or /\nResolved:\s+Open/) {
155+
if (/\nOpen/) {
155156
$code .= ' ' if $code;
156157
$code .= 'open';
157158
}

0 commit comments

Comments
 (0)