Skip to content

Commit fba0aa5

Browse files
committed
[css-font-load-events] Use the Promise hooks wording, add issues about what I plan to do with the promise values.
--HG-- extra : rebase_source : 29fa24075838487710abd9fab69f70087032a27e
1 parent 3244315 commit fba0aa5

2 files changed

Lines changed: 29 additions & 6 deletions

File tree

css-font-load-events/Overview.html

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
</a></p>
6969
<h1 class="p-name no-ref" id=title>CSS Font Load Events Module Level 3</h1>
7070
<h2 class="no-num no-toc no-ref heading settled heading" id=subtitle><span class=content>Editor’s Draft,
71-
<span class=dt-updated><span class=value-title title=20130902>2 September 2013</span></span></span></h2>
71+
<span class=dt-updated><span class=value-title title=20130903>3 September 2013</span></span></span></h2>
7272
<div data-fill-with=spec-metadata><dl><dt>This version:<dd><a class=u-url href=http://dev.w3.org/csswg/css-font-load-events/>http://dev.w3.org/csswg/css-font-load-events/</a><dt>Latest version:<dd><a href=http://www.w3.org/TR/css-font-load-events-3/>http://www.w3.org/TR/css-font-load-events-3/</a><dt>Editor’s Draft:<dd><a href=http://dev.w3.org/csswg/css-font-load-events/>http://dev.w3.org/csswg/css-font-load-events/</a>
7373
<dt>Feedback:</dt>
7474
<dd><a href="mailto:www-style@w3.org?subject=%5Bcss-font-load-events%5D%20feedback">www-style@w3.org</a>
@@ -420,6 +420,9 @@ <h5 class="heading settled heading" data-level=2.2.2.1 id=loadfont-method><span
420420
If the <var>font load list</var> contains no font faces,
421421
reject the promise with XXX.
422422

423+
<p class=issue id=issue-a2eabc2d><a class=self-link href=#issue-a2eabc2d></a>
424+
DOMError? Need to chat with Anne and others about idiomatic way to do errors.
425+
423426
<li>
424427
For all of the font faces in the <var>font load list</var>, initiate the load of any font that has
425428
not already been loaded and return.
@@ -428,11 +431,16 @@ <h5 class="heading settled heading" data-level=2.2.2.1 id=loadfont-method><span
428431
When all fonts in the <var>font load list</var> have been loaded,
429432
resolve the promise appropriately.
430433
If all fonts loaded successfully,
431-
accept the promise with XXX.
434+
fulfill the promise with XXX.
432435

433436
<p>
434437
If an error occurred with any one of the fonts in the <var>font load list</var>,
435438
reject the promise with XXX.
439+
440+
<p class=issue id=issue-290a86ee><a class=self-link href=#issue-290a86ee></a>
441+
When I define Font objects, and give them load() and ready() methods,
442+
I want to define this as simply adopting a Promise.every() of all the font ready promises.
443+
The fulfill/reject values then come out automatically.
436444
</ol>
437445

438446
<h5 class="heading settled heading" data-level=2.2.2.2 id=checkfont-method><span class=secno>2.2.2.2 </span><span class=content>
@@ -487,7 +495,7 @@ <h5 class="heading settled heading" data-level=2.2.2.3 id=ready-method><span cla
487495
before examining content which may be affected by loading fonts.
488496

489497
<p> Let <var>font loader</var> be the value of the <a class=idl-code data-link-type=attribute href=#dom-document-fontloader>fontloader</a> attribute of <var>doc</var>.
490-
The <var>font loader</var> contains a <dfn data-dfn-type=dfn data-export="" id=font-readiness-promise>font readiness promise<a class=self-link href=#font-readiness-promise></a></dfn>,
498+
The <var>font loader</var> contains an internal <dfn data-dfn-type=dfn data-export="" id=font-readiness-promise>font readiness promise<a class=self-link href=#font-readiness-promise></a></dfn>,
491499
which is initially set to a fresh pending Promise.
492500
If, after the document has finished loading and completed its initial layout,
493501
no fonts need to be loaded,
@@ -801,4 +809,11 @@ <h2 class="no-num heading settled" id=issues-index><span class=content>Issues In
801809
I’m just sketching the promise terminology here.
802810
Need to fill it in with the real stuff.
803811

804-
<a href=#issue-e86f85cf></a></div>
812+
<a href=#issue-e86f85cf></a><p class=issue>
813+
DOMError? Need to chat with Anne and others about idiomatic way to do errors.
814+
815+
<a href=#issue-a2eabc2d></a><p class=issue>
816+
When I define Font objects, and give them load() and ready() methods,
817+
I want to define this as simply adopting a Promise.every() of all the font ready promises.
818+
The fulfill/reject values then come out automatically.
819+
<a href=#issue-290a86ee></a></div>

css-font-load-events/Overview.src.html

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,9 @@ <h5 id='loadfont-method'>
347347
If the <var>font load list</var> contains no font faces,
348348
reject the promise with XXX.
349349

350+
<p class='issue'>
351+
DOMError? Need to chat with Anne and others about idiomatic way to do errors.
352+
350353
<li>
351354
For all of the font faces in the <var>font load list</var>, initiate the load of any font that has
352355
not already been loaded and return.
@@ -355,11 +358,16 @@ <h5 id='loadfont-method'>
355358
When all fonts in the <var>font load list</var> have been loaded,
356359
resolve the promise appropriately.
357360
If all fonts loaded successfully,
358-
accept the promise with XXX.
361+
fulfill the promise with XXX.
359362

360363
<p>
361364
If an error occurred with any one of the fonts in the <var>font load list</var>,
362365
reject the promise with XXX.
366+
367+
<p class='issue'>
368+
When I define Font objects, and give them load() and ready() methods,
369+
I want to define this as simply adopting a Promise.every() of all the font ready promises.
370+
The fulfill/reject values then come out automatically.
363371
</ol>
364372

365373
<h5 id='checkfont-method'>
@@ -414,7 +422,7 @@ <h5 id='ready-method'>
414422
before examining content which may be affected by loading fonts.
415423

416424
Let <var>font loader</var> be the value of the <a attribute>fontloader</a> attribute of <var>doc</var>.
417-
The <var>font loader</var> contains a <dfn export>font readiness promise</dfn>,
425+
The <var>font loader</var> contains an internal <dfn export>font readiness promise</dfn>,
418426
which is initially set to a fresh pending Promise.
419427
If, after the document has finished loading and completed its initial layout,
420428
no fonts need to be loaded,

0 commit comments

Comments
 (0)