Skip to content

Commit 4b7ecba

Browse files
authored
Tests: Run tests on both real Firefox ESRs
1. At the same time, there may be two supported versions of Firefox ESR. Run tests on both, installed locally. 2. Don't run tests on Firefox 115 on BrowserStack - it was added as there's an ESR version of Firefox 115, but ESR versions may be different, e.g. for some time ServiceWorker was disabled on ESR versions: https://bugzilla.mozilla.org/show_bug.cgi?id=1547023 Closes jquerygh-5547
1 parent 3658caf commit 4b7ecba

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

.github/workflows/browserstack.yml

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ jobs:
3131
- 'Edge_latest-1'
3232
- 'Firefox_latest'
3333
- 'Firefox_latest-1'
34-
- 'Firefox_115'
3534
- '__iOS_17'
3635
- '__iOS_16'
3736
- '__iOS_15'

.github/workflows/node.js.yml

+18-7
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ jobs:
3737
- NAME: "Chrome"
3838
NODE_VERSION: "20.x"
3939
NPM_SCRIPT: "test:esm"
40-
- NAME: "Firefox ESR"
40+
- NAME: "Firefox ESR (new)"
41+
NODE_VERSION: "20.x"
42+
NPM_SCRIPT: "test:firefox"
43+
- NAME: "Firefox ESR (old)"
4144
NODE_VERSION: "20.x"
4245
NPM_SCRIPT: "test:firefox"
4346
steps:
@@ -57,10 +60,21 @@ jobs:
5760
restore-keys: |
5861
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-npm-lock-
5962
60-
- name: Install firefox ESR
63+
- name: Set download URL for Firefox ESR (old)
64+
run: |
65+
echo "FIREFOX_SOURCE_URL=https://download.mozilla.org/?product=firefox-esr-latest-ssl&lang=en-US&os=linux64" >> "$GITHUB_ENV"
66+
if: contains(matrix.NAME, 'Firefox ESR (old)')
67+
68+
- name: Set download URL for Firefox ESR (new)
69+
run: |
70+
echo "FIREFOX_SOURCE_URL=https://download.mozilla.org/?product=firefox-esr-next-latest-ssl&lang=en-US&os=linux64" >> "$GITHUB_ENV"
71+
if: contains(matrix.NAME, 'Firefox ESR (new)')
72+
73+
- name: Install Firefox ESR
6174
run: |
62-
export FIREFOX_SOURCE_URL='https://download.mozilla.org/?product=firefox-esr-latest-ssl&lang=en-US&os=linux64'
6375
wget --no-verbose $FIREFOX_SOURCE_URL -O - | tar -jx -C ${HOME}
76+
echo "PATH=${HOME}/firefox:$PATH" >> "$GITHUB_ENV"
77+
echo "FIREFOX_BIN=${HOME}/firefox/firefox" >> "$GITHUB_ENV"
6478
if: contains(matrix.NAME, 'Firefox ESR')
6579

6680
- name: Install dependencies
@@ -71,10 +85,7 @@ jobs:
7185
if: contains(matrix.NPM_SCRIPT, 'lint')
7286

7387
- name: Run tests
74-
run: |
75-
export PATH=${HOME}/firefox:$PATH
76-
export FIREFOX_BIN=${HOME}/firefox/firefox
77-
npm run ${{ matrix.NPM_SCRIPT }}
88+
run: npm run ${{ matrix.NPM_SCRIPT }}
7889

7990
safari:
8091
runs-on: macos-latest

0 commit comments

Comments
 (0)