Skip to content

Commit a11e2d9

Browse files
committed
Selector: Use the nodeName util where possible to save size
Saves 33 bytes. Ref jquerygh-4504
1 parent 6dcf8cd commit a11e2d9

File tree

1 file changed

+16
-18
lines changed

1 file changed

+16
-18
lines changed

src/selector.js

+16-18
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
define( [
22
"./core",
3+
"./core/nodeName",
34
"./var/document",
45
"./var/indexOf",
56
"./var/hasOwn",
@@ -11,7 +12,7 @@ define( [
1112
// The following utils are attached directly to the jQuery object.
1213
"./selector/contains",
1314
"./selector/escapeSelector"
14-
], function( jQuery, document, indexOf, hasOwn, pop, push, sort, support ) {
15+
], function( jQuery, nodeName, document, indexOf, hasOwn, pop, push, sort, support ) {
1516

1617
"use strict";
1718

@@ -156,7 +157,7 @@ var i,
156157

157158
inDisabledFieldset = addCombinator(
158159
function( elem ) {
159-
return elem.disabled === true && elem.nodeName.toLowerCase() === "fieldset";
160+
return elem.disabled === true && nodeName( elem, "fieldset" );
160161
},
161162
{ dir: "parentNode", next: "legend" }
162163
);
@@ -354,8 +355,7 @@ function assert( fn ) {
354355
*/
355356
function createInputPseudo( type ) {
356357
return function( elem ) {
357-
var name = elem.nodeName.toLowerCase();
358-
return name === "input" && elem.type === type;
358+
return nodeName( elem, "input" ) && elem.type === type;
359359
};
360360
}
361361

@@ -365,8 +365,8 @@ function createInputPseudo( type ) {
365365
*/
366366
function createButtonPseudo( type ) {
367367
return function( elem ) {
368-
var name = elem.nodeName.toLowerCase();
369-
return ( name === "input" || name === "button" ) && elem.type === type;
368+
return ( nodeName( elem, "input" ) || nodeName( elem, "button" ) ) &&
369+
elem.type === type;
370370
};
371371
}
372372

@@ -882,13 +882,13 @@ Expr = jQuery.expr = {
882882
filter: {
883883

884884
TAG: function( nodeNameSelector ) {
885-
var nodeName = nodeNameSelector.replace( runescape, funescape ).toLowerCase();
885+
var expectedNodeName = nodeNameSelector.replace( runescape, funescape ).toLowerCase();
886886
return nodeNameSelector === "*" ?
887887
function() {
888888
return true;
889889
} :
890890
function( elem ) {
891-
return elem.nodeName && elem.nodeName.toLowerCase() === nodeName;
891+
return nodeName( elem, expectedNodeName );
892892
};
893893
},
894894

@@ -976,7 +976,7 @@ Expr = jQuery.expr = {
976976
node = elem;
977977
while ( ( node = node[ dir ] ) ) {
978978
if ( ofType ?
979-
node.nodeName.toLowerCase() === name :
979+
nodeName( node, name ) :
980980
node.nodeType === 1 ) {
981981

982982
return false;
@@ -1032,7 +1032,7 @@ Expr = jQuery.expr = {
10321032
( diff = nodeIndex = 0 ) || start.pop() ) ) {
10331033

10341034
if ( ( ofType ?
1035-
node.nodeName.toLowerCase() === name :
1035+
nodeName( node, name ) :
10361036
node.nodeType === 1 ) &&
10371037
++diff ) {
10381038

@@ -1198,9 +1198,8 @@ Expr = jQuery.expr = {
11981198

11991199
// In CSS3, :checked should return both checked and selected elements
12001200
// http://www.w3.org/TR/2011/REC-css3-selectors-20110929/#checked
1201-
var nodeName = elem.nodeName.toLowerCase();
1202-
return ( nodeName === "input" && !!elem.checked ) ||
1203-
( nodeName === "option" && !!elem.selected );
1201+
return ( nodeName( elem, "input" ) && !!elem.checked ) ||
1202+
( nodeName( elem, "option" ) && !!elem.selected );
12041203
},
12051204

12061205
selected: function( elem ) {
@@ -1246,13 +1245,12 @@ Expr = jQuery.expr = {
12461245
},
12471246

12481247
button: function( elem ) {
1249-
var name = elem.nodeName.toLowerCase();
1250-
return name === "input" && elem.type === "button" || name === "button";
1248+
return nodeName( elem, "input" ) && elem.type === "button" ||
1249+
nodeName( elem, "button" );
12511250
},
12521251

12531252
text: function( elem ) {
1254-
return elem.nodeName.toLowerCase() === "input" &&
1255-
elem.type === "text";
1253+
return nodeName( elem, "input" ) && elem.type === "text";
12561254
},
12571255

12581256
// Position-in-collection
@@ -1446,7 +1444,7 @@ function addCombinator( matcher, combinator, base ) {
14461444
if ( elem.nodeType === 1 || checkNonElements ) {
14471445
outerCache = elem[ expando ] || ( elem[ expando ] = {} );
14481446

1449-
if ( skip && skip === elem.nodeName.toLowerCase() ) {
1447+
if ( skip && nodeName( elem, skip ) ) {
14501448
elem = elem[ dir ] || elem;
14511449
} else if ( ( oldCache = outerCache[ key ] ) &&
14521450
oldCache[ 0 ] === dirruns && oldCache[ 1 ] === doneName ) {

0 commit comments

Comments
 (0)