Merge pull request #87 from michalkvasnicak/fix/resolve-option-resolver

Fix resolving resolve option

Author: michalkvasnicak

src/options_resolvers/resolve.js

@@ -13,11 +13,11 @@ export default function resolve(value/* , currentConfig */) {
         throw new Error(`Configuration 'resolve' is not an object`);
     }
 
-    if (alias in value && !isPlainObject(value.alias)) {
+    if ('alias' in value && !isPlainObject(value.alias)) {
         throw new Error(`Configuration 'resolve.alias' is not an object`);
     }
 
-    if (extensions in value) {
+    if ('extensions' in value) {
         if (!Array.isArray(value.extensions)) {
             throw new Error(`Configuration 'resolve.extensions' is not an array`);
         }
@@ -29,7 +29,7 @@ export default function resolve(value/* , currentConfig */) {
         });
     }
 
-    if (modules in value) {
+    if ('modules' in value) {
         if (!Array.isArray(value.modules)) {
             throw new Error(`Configuration 'resolve.modules' is not an array`);
         }
@@ -41,11 +41,11 @@ export default function resolve(value/* , currentConfig */) {
         });
     }
 
-    if (mainFile in value && !isString(value.mainFile)) {
+    if ('mainFile' in value && !isString(value.mainFile)) {
         throw new Error(`Configuration 'resolve.mainFile' is not a string`);
     }
 
-    if (preserveSymlinks in value && !isBoolean(value.preserveSymlinks)) {
+    if ('preserveSymlinks' in value && !isBoolean(value.preserveSymlinks)) {
         throw new Error(`Configuration 'resolve.preserveSymlinks' is not a boolean`);
     }
 

test/options_resolvers/resolve.spec.js

@@ -48,4 +48,24 @@ describe('options_resolvers/resolve', () => {
           () => resolve({ preserveSymlinks: 1 })
         ).to.throw();
     });
+
+    it('works if resolve.alias is an object', () => {
+        expect(() => resolve({ alias: {} })).to.not.throw();
+    });
+
+    it('works if resolve.extensions is an array of strings', () => {
+        expect(() => resolve({ extensions: ['a', 'b'] })).to.not.throw();
+    });
+
+    it('works if resolve.modules is an array of valid file paths', () => {
+        expect(() => resolve({ modules: [__dirname] })).to.not.throw();
+    });
+
+    it('works if resolve.mainFile is a string', () => {
+        expect(() => resolve({ mainFile: 'aa' })).to.not.throw();
+    });
+
+    it('works if resolve.preserveSymlinks is a boolean', () => {
+        expect(() => resolve({ preserveSymlinks: true })).to.not.throw();
+    });
 });