Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/commons-csv
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mina86/commons-csv
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 3, 2018

  1. Turn CSVRecord into a List

    CSVRecord implements get(int) and size() methods so it’s already pretty
    much a list.  However, because it does not implement the List interface,
    users cannot take advantage of convenience methods such as subList nor
    can they pass records around to methods accepting lists.
    
    Make CSVRecord extend AbstractList so that it implements List interface.
    
    Because AbstractList pravides iterator() implementation, this allows us
    to delete said method (alongside toList() method) reducing amount of
    code.
    mina86 committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    9256af7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Configuration menu
    Copy the full SHA
    81c2dba View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. document list is unmodifiable

    mina86 committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    5d43929 View commit details
    Browse the repository at this point in the history
Loading