Fix crash(es) upon upload failure. (commons-app#2699)

* Fix crash(es) upon upload failure.

* Further improve Rx structure.

Author: dbrant

app/src/main/java/fr/free/nrw/commons/mwapi/ApacheHttpClientMediaWikiApi.java

@@ -944,7 +944,7 @@ public Single<UploadStash> uploadFile(
             long dataLength,
             Uri fileUri,
             Uri contentProviderUri,
-            ProgressListener progressListener) throws IOException {
+            ProgressListener progressListener) {
         return Single.fromCallable(() -> {
             CustomApiResult result = api.uploadToStash(filename, file, dataLength, getEditToken(), progressListener::onProgress);
 

app/src/main/java/fr/free/nrw/commons/mwapi/MediaWikiApi.java

@@ -9,7 +9,6 @@
 import java.util.List;
 
 import fr.free.nrw.commons.Media;
-import fr.free.nrw.commons.campaigns.CampaignResponseDTO;
 import fr.free.nrw.commons.notification.Notification;
 import io.reactivex.Observable;
 import io.reactivex.Single;
@@ -53,7 +52,7 @@ public interface MediaWikiApi {
     @NonNull
     Single<UploadStash> uploadFile(String filename, InputStream file,
                                    long dataLength, Uri fileUri, Uri contentProviderUri,
-                                   final ProgressListener progressListener) throws IOException;
+                                   final ProgressListener progressListener);
 
     @NonNull
     Single<UploadResult> uploadFileFinalize(String filename, String filekey,

app/src/main/java/fr/free/nrw/commons/upload/UploadService.java

@@ -195,6 +195,7 @@ private NotificationCompat.Builder getNotificationBuilder(String channelId) {
                 .setContentIntent(PendingIntent.getActivity(this, 0, new Intent(this, MainActivity.class), 0));
     }
 
+    @SuppressLint("CheckResult")
     private void uploadContribution(Contribution contribution) {
         InputStream fileInputStream;
         Uri localUri = contribution.getLocalUri();
@@ -222,93 +223,89 @@ private void uploadContribution(Contribution contribution) {
 
         String filename = contribution.getFilename();
 
-        try {
+        NotificationUpdateProgressListener notificationUpdater = new NotificationUpdateProgressListener(notificationTag,
+                getString(R.string.upload_progress_notification_title_in_progress, contribution.getDisplayTitle()),
+                getString(R.string.upload_progress_notification_title_finishing, contribution.getDisplayTitle()),
+                contribution
+        );
 
+        Single.fromCallable(() -> {
             if (!mwApi.validateLogin()) {
                 // Need to revalidate!
                 if (sessionManager.revalidateAuthToken()) {
                     Timber.d("Successfully revalidated token!");
                 } else {
                     Timber.d("Unable to revalidate :(");
                     stopForeground(true);
-                    Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG);
-                    failureToast.show();
-                    sessionManager.forceLogin(this);
-                    return;
+                    sessionManager.forceLogin(UploadService.this);
+                    throw new RuntimeException(getString(R.string.authentication_failed));
                 }
             }
-            NotificationUpdateProgressListener notificationUpdater = new NotificationUpdateProgressListener(notificationTag,
-                    getString(R.string.upload_progress_notification_title_in_progress, contribution.getDisplayTitle()),
-                    getString(R.string.upload_progress_notification_title_finishing, contribution.getDisplayTitle()),
-                    contribution
-            );
-            String stashFilename = "Temp_" + contribution.hashCode() + filename;
-            mwApi.uploadFile(
-                    stashFilename, fileInputStream, contribution.getDataLength(),
-                    localUri, contribution.getContentProviderUri(), notificationUpdater)
-                    .subscribeOn(Schedulers.io())
-                    .observeOn(Schedulers.io())
-                    .flatMap(uploadStash -> {
-                        notificationManager.cancel(NOTIFICATION_UPLOAD_IN_PROGRESS);
-
-                        Timber.d("Stash upload response 1 is %s", uploadStash.toString());
-
-                        String resultStatus = uploadStash.getResultStatus();
-                        if (!resultStatus.equals("Success")) {
-                            Timber.d("Contribution upload failed. Wikidata entity won't be edited");
-                            showFailedNotification(contribution);
-                            return Single.never();
-                        } else {
-                            synchronized (unfinishedUploads) {
-                                Timber.d("making sure of uniqueness of name: %s", filename);
-                                String uniqueFilename = findUniqueFilename(filename);
-                                unfinishedUploads.add(uniqueFilename);
-                                return mwApi.uploadFileFinalize(
-                                        uniqueFilename,
-                                        uploadStash.getFilekey(),
-                                        contribution.getPageContents(getApplicationContext()),
-                                        contribution.getEditSummary());
-                            }
-                        }
-                    })
-                    .subscribe(uploadResult -> {
-                        Timber.d("Stash upload response 2 is %s", uploadResult.toString());
-
-                        notificationManager.cancel(notificationTag, NOTIFICATION_UPLOAD_IN_PROGRESS);
-
-                        String resultStatus = uploadResult.getResultStatus();
-                        if (!resultStatus.equals("Success")) {
-                            Timber.d("Contribution upload failed. Wikidata entity won't be edited");
-                            showFailedNotification(contribution);
-                        } else {
-                            String canonicalFilename = uploadResult.getCanonicalFilename();
-                            Timber.d("Contribution upload success. Initiating Wikidata edit for entity id %s",
-                                    contribution.getWikiDataEntityId());
-                            wikidataEditService.createClaimWithLogging(contribution.getWikiDataEntityId(), canonicalFilename);
-                            contribution.setFilename(canonicalFilename);
-                            contribution.setImageUrl(uploadResult.getImageUrl());
-                            contribution.setState(Contribution.STATE_COMPLETED);
-                            contribution.setDateUploaded(uploadResult.getDateUploaded());
-                            contributionDao.save(contribution);
+            return "Temp_" + contribution.hashCode() + filename;
+        }).flatMap(stashFilename -> mwApi.uploadFile(
+                stashFilename, fileInputStream, contribution.getDataLength(),
+                localUri, contribution.getContentProviderUri(), notificationUpdater))
+                .subscribeOn(Schedulers.io())
+                .observeOn(Schedulers.io())
+                .doFinally(() -> {
+                    if (filename != null) {
+                        unfinishedUploads.remove(filename);
+                    }
+                    toUpload--;
+                    if (toUpload == 0) {
+                        // Sync modifications right after all uploads are processed
+                        ContentResolver.requestSync(sessionManager.getCurrentAccount(), BuildConfig.MODIFICATION_AUTHORITY, new Bundle());
+                        stopForeground(true);
+                    }
+                })
+                .flatMap(uploadStash -> {
+                    notificationManager.cancel(NOTIFICATION_UPLOAD_IN_PROGRESS);
+
+                    Timber.d("Stash upload response 1 is %s", uploadStash.toString());
+
+                    String resultStatus = uploadStash.getResultStatus();
+                    if (!resultStatus.equals("Success")) {
+                        Timber.d("Contribution upload failed. Wikidata entity won't be edited");
+                        showFailedNotification(contribution);
+                        return Single.never();
+                    } else {
+                        synchronized (unfinishedUploads) {
+                            Timber.d("making sure of uniqueness of name: %s", filename);
+                            String uniqueFilename = findUniqueFilename(filename);
+                            unfinishedUploads.add(uniqueFilename);
+                            return mwApi.uploadFileFinalize(
+                                    uniqueFilename,
+                                    uploadStash.getFilekey(),
+                                    contribution.getPageContents(getApplicationContext()),
+                                    contribution.getEditSummary());
                         }
-                    }, throwable -> {
-                        throw new RuntimeException(throwable);
-                    });
-        } catch (IOException e) {
-            Timber.w(e,"IOException during upload");
-            notificationManager.cancel(NOTIFICATION_UPLOAD_IN_PROGRESS);
-            showFailedNotification(contribution);
-        } finally {
-            if (filename != null) {
-                unfinishedUploads.remove(filename);
-            }
-            toUpload--;
-            if (toUpload == 0) {
-                // Sync modifications right after all uplaods are processed
-                ContentResolver.requestSync(sessionManager.getCurrentAccount(), BuildConfig.MODIFICATION_AUTHORITY, new Bundle());
-                stopForeground(true);
-            }
-        }
+                    }
+                })
+                .subscribe(uploadResult -> {
+                    Timber.d("Stash upload response 2 is %s", uploadResult.toString());
+
+                    notificationManager.cancel(notificationTag, NOTIFICATION_UPLOAD_IN_PROGRESS);
+
+                    String resultStatus = uploadResult.getResultStatus();
+                    if (!resultStatus.equals("Success")) {
+                        Timber.d("Contribution upload failed. Wikidata entity won't be edited");
+                        showFailedNotification(contribution);
+                    } else {
+                        String canonicalFilename = uploadResult.getCanonicalFilename();
+                        Timber.d("Contribution upload success. Initiating Wikidata edit for entity id %s",
+                                contribution.getWikiDataEntityId());
+                        wikidataEditService.createClaimWithLogging(contribution.getWikiDataEntityId(), canonicalFilename);
+                        contribution.setFilename(canonicalFilename);
+                        contribution.setImageUrl(uploadResult.getImageUrl());
+                        contribution.setState(Contribution.STATE_COMPLETED);
+                        contribution.setDateUploaded(uploadResult.getDateUploaded());
+                        contributionDao.save(contribution);
+                    }
+                }, throwable -> {
+                    Timber.w(throwable, "Exception during upload");
+                    notificationManager.cancel(NOTIFICATION_UPLOAD_IN_PROGRESS);
+                    showFailedNotification(contribution);
+                });
     }
 
     @SuppressLint("StringFormatInvalid")