Don't put local URI into thumbnail cache.

dbrant · dbrant · commit 39e24b1863c5 · 2017-05-20T15:32:41.000+02:00
diff --git a/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java b/app/src/main/java/fr/free/nrw/commons/MediaWikiImageView.java
@@ -64,8 +64,10 @@ protected void onPostExecute(String result) {
             }
             if (TextUtils.isEmpty(result) && media.getLocalUri() != null) {
                 result = media.getLocalUri().toString();
+            } else {
+                // only cache meaningful thumbnails received from network.
+                CommonsApplication.getInstance().getThumbnailUrlCache().put(media.getFilename(), result);
             }
-            CommonsApplication.getInstance().getThumbnailUrlCache().put(media.getFilename(), result);
             setImageUrl(result);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,10 @@ protected void onPostExecute(String result) {`
`64`	`64`	`}`
`65`	`65`	`if (TextUtils.isEmpty(result) && media.getLocalUri() != null) {`
`66`	`66`	`result = media.getLocalUri().toString();`
	`67`	`+ } else {`
	`68`	`+ // only cache meaningful thumbnails received from network.`
	`69`	`+ CommonsApplication.getInstance().getThumbnailUrlCache().put(media.getFilename(), result);`
`67`	`70`	`}`
`68`		`- CommonsApplication.getInstance().getThumbnailUrlCache().put(media.getFilename(), result);`
`69`	`71`	`setImageUrl(result);`
`70`	`72`	`}`
`71`	`73`	`}`