Skip to content

Commit 8abda82

Browse files
committed
rather critical fix for issue 115. min/max attributes made the field required by default. not anymore.
1 parent e50a204 commit 8abda82

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/validator/validator.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,17 +226,25 @@
226226
// skip dateinputs
227227
if ($.tools.dateinput && el.is(":date")) { return true; }
228228

229+
// skip empty values
230+
v = parseFloat(v);
231+
if (isNaN(v)) { return true; }
232+
229233
var max = el.attr("max");
230-
return parseFloat(v) <= parseFloat(max) ? true : [max];
234+
return v <= parseFloat(max) ? true : [max];
231235
});
232236

233237
v.fn("[min]", "Please enter a value larger than $1", function(el, v) {
234-
238+
235239
// skip dateinputs
236240
if ($.tools.dateinput && el.is(":date")) { return true; }
237241

242+
// skip empty values
243+
v = parseFloat(v);
244+
if (isNaN(v)) { return true; }
245+
238246
var min = el.attr("min");
239-
return parseFloat(v) >= parseFloat(min) ? true : [min];
247+
return v >= parseFloat(min) ? true : [min];
240248
});
241249

242250
v.fn("[required]", "Please complete this mandatory field.", function(el, v) {

test/validator/validator.htm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
</p>
6969

7070
<p>
71-
[number] <input type="number" value="123" />
71+
[number] <input type="text" min="0" />
7272
</p>
7373

7474
<input type="submit" />

0 commit comments

Comments
 (0)